Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme.html #4632

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Update theme.html #4632

merged 1 commit into from
Mar 28, 2022

Conversation

brwnie
Copy link
Contributor

@brwnie brwnie commented Dec 15, 2021

Footer links refer to the template of '1 - Main' rather than '3 - Footer'

I've noticed the main navigation links are copied three times across the page, at the header, sidebar, and directly underneath in the footer. This leaves the template categories 2 - Sidebar and 3 - Footer unused

Motivation and Context

Allows the template categories to be utilised in the navigation area of the admin panel

Description

Single word change from 'main' to 'footer'

How Has This Been Tested?

Tested on own website

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

Footer links refer to the template of '1 - Main' rather than '3 - Footer'
@Jimmi08
Copy link
Contributor

Jimmi08 commented Dec 16, 2021

@brwnie
It is not a bug, it was the intention (at least at the beginning), but I could be wrong.

Just notes:
You should never use the core theme directly. This was just an example of how to use a different set of links with another template. Otherwise, you should use {NAVIGATION=footer} to get your result.

With this change, you should add demo data (install.xml) to this theme, otherwise, no links will be displayed.

@CaMer0n CaMer0n added this to the e107 2.3.2 milestone Mar 28, 2022
@CaMer0n CaMer0n merged commit dd62412 into e107inc:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants