Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index to database session handler for session expiry #4575

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

Deltik
Copy link
Member

@Deltik Deltik commented Sep 25, 2021

Fixes: #4574

Motivation and Context

Adding an index on the session expiry field in the session table greatly improves garbage collection performance

Description

Add an index for e107_session.session_expiry

How Has This Been Tested?

Manual acceptance test: Observed that site loads faster after adding the new index on a site with a million rows in the e107_session table

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

Greatly improves garbage collection performance

Fixes: e107inc#4574
@Deltik Deltik requested a review from CaMer0n September 25, 2021 20:17
@codeclimate
Copy link

codeclimate bot commented Sep 25, 2021

Code Climate has analyzed commit 54ed823 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 34.4% (0.1% change).

View more on Code Climate.

@CaMer0n
Copy link
Member

CaMer0n commented Sep 27, 2021

Thank you! 👍

@CaMer0n CaMer0n merged commit c7dc227 into e107inc:master Sep 27, 2021
@Deltik Deltik deleted the fix/4574 branch September 28, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor performance with many rows in e107_session table
2 participants