Migrate database charset to utf8mb4 and storage engine to InnoDB #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnoDB storage engine
Components affected:
* `db_verify` now checks and corrects the table storage engine
* `db_verify` now checks and corrects the table default character set
* Note: Field character sets can still be overridden
* Note: When correcting, the entire table is converted to the target
charset.
* The alt_auth plugin now connects via PDO using the e107 default
charset, utf8mb4
* `e_db_pdo` now sets the charset to utf8mb4. This is currently not
customizable because it was previously not customizable.
* `install.php` now generates an `e107_config.php` file with
`$mySQLcharset = 'utf8mb4';`, though this option is not actually used.
* `install.php` now removes plugin tables before installing plugins.
* `e_db_mysql` now only accepts the `utf8mb4` charset. Previously, it
only accepted the `utf8` charset.
* `e_db_mysql` now configures `mysqli_real_escape_string` to match the
new default charset, `utf8mb4`.
* Plugin installations now use the preferred MySQL table storage engines
and charsets.
The preferred MySQL table storage engines are now mapped like so:
* If `ENGINE=MyISAM` is specified, the actual storage engine set will be
the first available of: InnoDB, Aria, Maria, MyISAM
* If `ENGINE=Aria` is specified, the actual storage engine set will be
the first available of: Aria, Maria, MyISAM
* If `ENGINE=InnoDB` is specified, the actual storage engine set will be
the first available of: InnoDB, XtraDB
* If `ENGINE=XtraDB` is specified, the actual storage engine set will be
the first available of: XtraDB, InnoDB
The preferred MySQL character set is now aliased like so:
* `utf8` => `utf8mb4`
* `utf8mb3` => `utf8mb3`
* `utf8mb4` => `utf8mb4`
Fixes: e107inc#4501
Deltik
force-pushed
the
fix/4501
branch
5 times, most recently
from
01e1680
to
d793b7f
Compare
Deltik
force-pushed
the
fix/4501
branch
4 times, most recently
from
29d9ffd
to
78d9e4b
Compare
Deltik
force-pushed
the
fix/4501
branch
5 times, most recently
from
4f99536
to
1b08eb0
Compare
CaMer0n
reviewed
Sep 14, 2021
Deltik
force-pushed
the
fix/4501
branch
2 times, most recently
from
e2553df
to
363fc99
Compare
Deltik
force-pushed
the
master
branch
2 times, most recently
from
9119ebf
to
2a0ee3f
Compare
|
Code Climate has analyzed commit d790faa and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 43.1% (80% is the threshold). This pull request will bring the total coverage in the repository to 39.1% (-0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4501
Motivation and Context
Add emoji support and stop using the obsolete MyISAM storage engine
Description
Convert and run e107 using the MySQL/MariaDB utf8mb4 character set and InnoDB storage engine
Components affected:
db_verifynow checks and corrects the table storage enginedb_verifynow checks and corrects the table default character setcharset.
charset, utf8mb4
e_db_pdonow sets the charset to utf8mb4. This is currently notcustomizable because it was previously not customizable.
install.phpnow generates ane107_config.phpfile with$mySQLcharset = 'utf8mb4';, though this option is not actually used.install.phpnow removes plugin tables before installing plugins.e_db_mysqlnow only accepts theutf8mb4charset. Previously, itonly accepted the
utf8charset.e_db_mysqlnow configuresmysqli_real_escape_stringto match thenew default charset,
utf8mb4.and charsets.
The preferred MySQL table storage engines are now mapped like so:
ENGINE=MyISAMis specified, the actual storage engine set will bethe first available of: InnoDB, Aria, Maria, MyISAM
ENGINE=Ariais specified, the actual storage engine set will bethe first available of: Aria, Maria, MyISAM
ENGINE=InnoDBis specified, the actual storage engine set will bethe first available of: InnoDB, XtraDB
ENGINE=XtraDBis specified, the actual storage engine set will bethe first available of: XtraDB, InnoDB
The preferred MySQL character set is now aliased like so:
utf8=>utf8mb4utf8mb3=>utf8mb3utf8mb4=>utf8mb4How Has This Been Tested?
Unit tests included in pull request
Types of Changes
Checklist