Fix forum #3490
Merged
Fix forum #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent @phibel ! Thank you! The code looks good to me though. |
…other forum I am working further on the moderator permissions and discovered that my previous commit 692509f is a bad solution. Because the moderator submits the threadId and postID for the post who he wants to delete. This threadId was used to check the moderator permissions of the postId. So if a moderator has only permissions for one forum, he could change the transmitted threadId in an other forum to get there also moderator permisssions... Sorry that I did not noticed this glitch before I made the previous commit. :-/
Without admin permissions (member of user class 254) it was not possible to modify threads in the forum. This fix get the forum-moderator permissions by the threadId to modify this thread.
Looks like someone was interrupted during work and than it was merged into the repo? Anyway, the needed information are stored in $postInfo[] and not in $row[].
phibel
commented
Oct 13, 2018
| if(!is_array($postInfo) || empty($postInfo)) | ||
| { | ||
| echo 'NOT FOUND!'; return; | ||
| return null; |
There was a problem hiding this comment.
Changed the return here to "null" and adapted the description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.