Remove and optimize (hardcoded) LANS #6

CaMer0n · 2012-11-28T00:14:21Z

Remove all hard-coded terms from e107 and optimize!

Translator's Checklist:

Remove any HTML from the LAN (bbcodes are okay)
Use double-quotes. eg. define("LAN_01", "It's all good");
Make sure "LAN" is used inside the constant name.
Do not leave empty or unused defines. eg define("LAN_SOMETHING", ""); instead, comment them out with //
Use $tp->lanVars() for variables conversion. eg. [x] etc.
Check for duplicate/similar terms (admin only) against lan_admin.php (eg. LAN_UPDATE)
Check for duplicate/similar terms (frontend or admin) against e107_languages/English/English.php
Reduce the number of 'defines' as much as possible by using generic terms.
Do NOT translate debug information. (eg. anything inside addDebug(); or "E107_DEBUG_LEVEL >0" etc. )
Do NOT translate anything used within e_DEVELOPER.
If you find a recurring word/term appearing in several areas of e107, please mention it here as a 'generic' candidate in this issue.

Work in progress.

…ogress! (#90, #6)

, #6)

… Headers updated.

Issue #6 Grammatical edits

ToDo Lans bounceLAN in handlers/login. Tested login from login.php, from the login link in voux theme without issue. No bounced emails on test instance.

This reverts commit 7160330.

Was already available in admin

Error message from Code Climate: > Exception: The given file "/code/e107_tests/lib/ci/salt/pillars/config-local.sls" does not exist. in /usr/src/app/vendor/pdepend/pdepend/src/main/php/PDepend/Engine.php > #0 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(129): PDepend\Engine->addFile('/code/e107_test...') > #1 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(109): PHPMD\ParserFactory->initInput(Object(PDepend\Engine), Object(PHPMD\PHPMD)) > #2 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(76): PHPMD\ParserFactory->init(Object(PDepend\Engine), Object(PHPMD\PHPMD)) > #3 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/PHPMD.php(215): PHPMD\ParserFactory->create(Object(PHPMD\PHPMD)) > #4 /usr/src/app/Runner.php(116): PHPMD\PHPMD->processFiles('/code/e107_test...', 'cleancode,unuse...', Array, Object(PHPMD\RuleSetFactory)) > #5 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1852): CodeClimate\PHPMD\Runner->run(Array) > #6 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1772): fork_daemon->invoke_callback(Array, Array, false) > #7 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1673): fork_daemon->fork_work_unit(Array, '', -1) > #8 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1445): fork_daemon->process_work_unit(-1) > #9 /usr/src/app/Runner.php(31): fork_daemon->process_work(false) > #10 /usr/src/app/engine.php(35): CodeClimate\PHPMD\Runner->queueDirectory('/code') > #11 {main}

Moc · 2019-12-28T19:02:14Z

@CaMer0n was this one closed intentionally?

CaMer0n · 2019-12-28T19:46:56Z

@Moc No. Looks like it came with the pull-request.

--------- 1) lancheckTest: Is_utf8 Test tests/unit/lancheckTest.php:testIs_utf8 [PHPUnit_Framework_Exception] Constant LAN_SETSAVED already defined #1 Codeception\Subscriber\ErrorHandler->errorHandler #2 /__w/e107/e107/e107_languages/English/admin/lan_admin.php:262 #3 /__w/e107/e107/e107_handlers/e107_class.php:3156 #4 /__w/e107/e107/e107_handlers/e107_class.php:3182 #5 /__w/e107/e107/e107_admin/lancheck.php:18 #6 /__w/e107/e107/e107_tests/tests/unit/lancheckTest.php:18 #7 {closure}

Bugs fixed: * Security failure status is now prioritized in file_inspector::getStatusForValidationCode() * File Inspector list view now supports filters

Issue #6 LAN Corrections.

``` [Sat Nov 28 07:42:08.146694 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: PHP Fatal error: Uncaught Error: Non-static method e_date::convert_date() cannot be called statically in ~/public_html/e107_handlers/bbcode_handler.php(390) : eval()'d code:6 [Sat Nov 28 07:42:08.146832 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: Stack trace: [Sat Nov 28 07:42:08.146841 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: #0 ~/public_html/e107_handlers/bbcode_handler.php(390): eval() [Sat Nov 28 07:42:08.146848 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#1 ~/public_html/e107_handlers/bbcode_handler.php(202): e_bbcode->proc_bbcode() [Sat Nov 28 07:42:08.146853 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#2 ~/public_html/e107_handlers/e_parse_class.php(1919): e_bbcode->parseBBCodes() [Sat Nov 28 07:42:08.146859 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#3 ~/public_html/e107_core/shortcodes/batch/comment_shortcodes.php(350): e_parse->toHTML() [Sat Nov 28 07:42:08.146882 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#4 ~/public_html/e107_handlers/shortcode_handler.php(1119): comment_shortcodes->sc_comment() [Sat Nov 28 07:42:08.146888 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#5 [internal function]: e_parse_shortcode->doCode() [Sat Nov 28 07:42:08.146908 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#6 ~/public_html/e107_handlers/shortcode_handler.php(986): preg_replace_callback() [Sat Nov 28 07:42:08.146914 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#7 ~/public_html/e107_handlers/e_parse_class.php(883): e_parse_shortcode->parseCodes() [Sat Nov 28 07:42:08.146920 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#8 ~/public_html/e107_handlers/comment_class.php(534): e_parse->parseTemplate() [Sat Nov 28 07:42:08.146926 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#9 ~/public_html/e107_handlers/comment_class.php(1301): comment->render_comment() [Sat Nov 28 07:42:08.146931 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#10 ~/public_html/e107_handlers/comment_class.php(1125): comment->getComments() [Sat Nov 28 07:42:08.146938 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#11 ~/public_html/e107_plugins/news/news.php(1299): comment->compose_comment() [Sat Nov 28 07:42:08.146943 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#12 ~/public_html/e107_plugins/news/news.php(236): news_front->renderComments() [Sat Nov 28 07:42:08.146950 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#13 ~/public_html/e107_plugins/news/news.php(1895): news_front->render() [Sat Nov 28 07:42:08.146955 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#14 ~/public_html/news.php(23): require_once('...') [Sat Nov 28 07:42:08.146961 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#15 ~/public_html/index.php(103): include('...') [Sat Nov 28 07:42:08.146967 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#16 {main} [Sat Nov 28 07:42:08.146972 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: thrown in ~/public_html/e107_handlers/bbcode_handler.php(390) : eval()'d code on line 6 ```

``` PHP Fatal error: Uncaught TypeError: Unsupported operand types: array & int in ~/public_html/e107_admin/fileinspector.php:1266 Stack trace: #0 ~/public_html/e107_admin/fileinspector.php(717): file_inspector->getOldVersionOfPath() #1 ~/public_html/e107_admin/fileinspector.php(677): file_inspector->generateDirectoryHtml() #2 ~/public_html/e107_admin/fileinspector.php(961): file_inspector->generateScanResultsHtml() #3 ~/public_html/e107_admin/fileinspector.php(156): file_inspector->scan_results() #4 ~/public_html/e107_handlers/admin_ui.php(1076): fileinspector_admin->init() #5 ~/public_html/e107_admin/fileinspector.php(249): e_admin_dispatcher->__construct() #6 {main} thrown in ~/public_html/e107_admin/fileinspector.php on line 1266 ```

--------- 1) e_navigationTest: Admin links plugins Test tests/unit/e_navigationTest.php:testAdminLinksPlugins Error: ;1m [Error] Undefined constant "E_16_PLUGMANAGER" e107inc#1 /__w/e107/e107/e107_handlers/sitelinks_class.php:882 e107inc#2 /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:528 --------- 2) e_navigationTest: Admin links legacy Test tests/unit/e_navigationTest.php:testAdminLinksLegacy Error: ;1m [Error] Undefined constant "E_32_MAIN" e107inc#1 /__w/e107/e107/e107_handlers/sitelinks_class.php:735 e107inc#2 /__w/e107/e107/e107_handlers/sitelinks_class.php:887 e107inc#3 /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:374 --------- 3) e_formTest: Render value Test tests/unit/e_formTest.php:testRenderValue Error: ;1m [Error] Undefined constant "ADMIN_TRUE_ICON" e107inc#1 /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:943 --------- 4) scriptsTest: Admin scripts Test tests/unit/scriptsTest.php:testAdminScripts Error: ;1m [Error] Undefined constant "E_32_MAIN" e107inc#1 /__w/e107/e107/e107_handlers/sitelinks_class.php:735 e107inc#2 /__w/e107/e107/e107_handlers/sitelinks_class.php:887 e107inc#3 /__w/e107/e107/e107_admin/includes/infopanel.php:110 e107inc#4 /__w/e107/e107/e107_admin/includes/flexpanel.php:66 e107inc#5 /__w/e107/e107/e107_admin/admin.php:63 e107inc#6 /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140 e107inc#7 /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:27 --------- 5) e_formTest: Render value inline Test tests/unit/e_formTest.php:testRenderValueInline Error: ;1m [Error] Undefined constant "ADMIN_FALSE_ICON" e107inc#1 /__w/e107/e107/e107_handlers/form_handler.php:5829 e107inc#2 /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:1029 --------- 6) e_navigationTest: Admin links sub Test tests/unit/e_navigationTest.php:testAdminLinksSub Error: ;1m [Error] Undefined constant "E_32_MAIN" e107inc#1 /__w/e107/e107/e107_handlers/sitelinks_class.php:735 e107inc#2 /__w/e107/e107/e107_handlers/sitelinks_class.php:887 e107inc#3 /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:418 --------- 7) e_parse_shortcodeTest: Admin shortcodes Test tests/unit/e_parse_shortcodeTest.php:testAdminShortcodes Error: ;1m [Error] Undefined constant "E_16_NEWS" e107inc#1 /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:518 e107inc#2 /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:602 e107inc#3 /__w/e107/e107/e107_handlers/shortcode_handler.php:1130 e107inc#4 e_parse_shortcode->doCode e107inc#5 /__w/e107/e107/e107_handlers/shortcode_handler.php:996 e107inc#6 /__w/e107/e107/e107_handlers/e_parse_class.php:823 e107inc#7 /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:1588 e107inc#8 /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:220 --------- 8) scriptsTest: Admin includes Test tests/unit/scriptsTest.php:testAdminIncludes Error: ;1m [Error] Undefined constant "E_32_MAIN" e107inc#1 /__w/e107/e107/e107_handlers/sitelinks_class.php:735 e107inc#2 /__w/e107/e107/e107_handlers/sitelinks_class.php:887 e107inc#3 /__w/e107/e107/e107_admin/includes/categories.php:22 e107inc#4 /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140 e107inc#5 /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:36 -- There was 1 failure: --------- 1) e107Test: Load admin icons Test tests/unit/e107Test.php:testLoadAdminIcons E_16_FACEBOOK is missing from admin_icons_template e107inc#1 /__w/e107/e107/e107_tests/tests/unit/e107Test.php:1054

…Extra checks to e_parse to avoid possible errors.

Issue #6 global LAN_META_DESCRIPTION and LAN_META_TITLE added and replacements made throughout.

Issue #6 LAN corrections

…s to cron admin area.

Issue #6 Existing text to LAN's

ghost assigned Moc Nov 28, 2012

Moc added a commit that referenced this issue Nov 28, 2012

GUI fixes to system logs and LAN optimization (#6)

289f890

Moc added a commit that referenced this issue Nov 30, 2012

Start on GUI of forum admin, also #6 LAN improvements.

c756395

Work in progress.

Moc added a commit that referenced this issue Dec 6, 2012

More event calendar GUI clean-up and #6 LAN improvement

1972441

This was referenced Dec 19, 2012

Global lans for plugins #50

Closed

incorrect text added to sitelinks from download plugin #65

Closed

Moc added a commit that referenced this issue Feb 4, 2013

message consistency (#90) and LAN optimization (#6)

056ad7f

Moc added a commit that referenced this issue Feb 4, 2013

Issue #90 - Trackback plugin (also #6)

a97020c

Moc added a commit that referenced this issue Feb 4, 2013

Issue #90 - Banner plugin (also #6 and GUI styling)

9547df9

Moc added a commit that referenced this issue Feb 4, 2013

Issue #90 - Chatbox plugin (also #6)

6f45a69

Moc added a commit that referenced this issue Feb 5, 2013

LAN optimization (#6) - Newspost

6e54d14

Moc added a commit that referenced this issue Feb 5, 2013

Issue #90 - Event calendar plugin - WIP (also #6)

bc865d9

Moc added a commit that referenced this issue Feb 6, 2013

Issue #90 - Forum plugin (also #6 and GUI styling)

c923ed8

Moc added a commit that referenced this issue Feb 6, 2013

Issue #90 - Linkwords plugin (also #6 and GUI styling)

da62465

Moc added a commit that referenced this issue Feb 7, 2013

Issue #90 - Newsfeed plugin (also #6 and GUI styling)

31e52b7

Moc added a commit that referenced this issue Feb 7, 2013

Issue #90 - Blogcalendar menu (also #6 and GUI styling)

79a9906

Moc added a commit that referenced this issue Feb 7, 2013

Clock_menu clean-up (#6, #90) - LAN and GUI

c323ed4

Moc added a commit that referenced this issue Feb 7, 2013

Comment_menu clean-up (#6, #90) - LAN and GUI

ac2debe

Moc added a commit that referenced this issue Feb 7, 2013

Issue #90 - Welcome messages (also GUI styling and #6)

4fc76fe

Moc added a commit that referenced this issue Feb 8, 2013

#6 LAN optimization (LAN_EMAIL)

a561aa0

Moc added a commit that referenced this issue Feb 8, 2013

Newsletter plugin major clean-up. GUI and LAN optimization (#90, #6)

44dba93

Moc added a commit that referenced this issue Feb 10, 2013

Forum plugin - code clean-up, message and LAN consistency. Work in pr…

8d2b682

…ogress! (#90, #6)

Moc added a commit that referenced this issue Feb 10, 2013

Online menu (last seen menu) code and LAN clean-up (#90, #6)

ba199e0

Moc added a commit that referenced this issue Feb 10, 2013

PM Plugin - $emessage to $mes and minor LAN updates (#90, #6)

57dfccc

Moc added a commit that referenced this issue Feb 10, 2013

Tree_menu basic code and GUI clean-up. Also LAN (#90, #6)

2d4ad64

Moc added a commit that referenced this issue Feb 20, 2013

Event calendar plugin - code clean-up, message and LAN consistency. (#90

acdfb54

, #6)

Moc added a commit that referenced this issue Feb 25, 2013

LAN enhancement (news) #6

e75e535

Moc added a commit that referenced this issue Feb 25, 2013

Frontpage (admin area) - LAN (#6) and code clean-up

0e01bbb

Moc added a commit that referenced this issue Feb 26, 2013

Meta tags - Code and LAN clean-up (#6)

10c215e

Moc added a commit that referenced this issue Feb 27, 2013

Various clean-up (#6, #125, 90). Removal of message and form handler.…

adc9859

… Headers updated.

CaMer0n added a commit that referenced this issue Jul 27, 2018

Merge pull request #3323 from Michaelkielstra/master

0f5396f

Issue #6 Grammatical edits

CaMer0n added a commit that referenced this issue Aug 18, 2018

Fixes #3070 Featurebox LANs Issue #6

968a6d0

CaMer0n added a commit that referenced this issue Aug 26, 2018

Issue #2669 Incorrect FB og:image used. Issue #6 LAN modified.

f958f66

MikeyGMT added a commit to MikeyGMT/e107 that referenced this issue Nov 3, 2018

e107inc#6 ToDo Lans bounceLAN in handlers/login

7160330

ToDo Lans bounceLAN in handlers/login. Tested login from login.php, from the login link in voux theme without issue. No bounced emails on test instance.

MikeyGMT added a commit to MikeyGMT/e107 that referenced this issue Nov 3, 2018

Revert "e107inc#6 ToDo Lans bounceLAN in handlers/login"

8b020b7

This reverts commit 7160330.

Moc added a commit that referenced this issue Feb 22, 2019

#6 - Add some generic LAN frontend

2c17c4f

Was already available in admin

LaocheXe mentioned this issue Mar 23, 2019

Editing member info with extended user fields gives an error #3746

Closed

CaMer0n closed this as completed in 16e04d8 Dec 28, 2019

CaMer0n reopened this Dec 28, 2019

Kojack-59 referenced this issue Mar 29, 2020

Implemented insecure file check in File Inspector

03dfb5c

Bugs fixed: * Security failure status is now prioritized in file_inspector::getStatusForValidationCode() * File Inspector list view now supports filters

CaMer0n added a commit that referenced this issue Jul 1, 2020

Merge pull request #4043 from yesszus/patch-1

5f58f8f

Issue #6 LAN Corrections.

tgtje mentioned this issue Apr 5, 2021

Cannot download msi file from download manager #4478

Closed

mgaulton mentioned this issue Jun 28, 2021

Blank page suddenly after no changes recently. #4524

Closed

CaMer0n added a commit that referenced this issue Sep 28, 2021

Issue #6 LANS added. Clear system cache before checking for updates. …

5ecc0be

…Extra checks to e_parse to avoid possible errors.

CaMer0n added a commit that referenced this issue Jun 9, 2022

Closes #4783 Added Page Meta-Title field and synced with Page title.

52cf8f5

Issue #6 global LAN_META_DESCRIPTION and LAN_META_TITLE added and replacements made throughout.

CaMer0n added a commit that referenced this issue Jul 15, 2022

Merge pull request #4788 from yesszus/patch-2

1792aee

Issue #6 LAN corrections

CaMer0n added a commit that referenced this issue Nov 4, 2023

Issue #6 - LAN_CRON_61 modified to 'token'. Minor styling improvement…

eee2ae0

…s to cron admin area.

CaMer0n added a commit that referenced this issue May 10, 2024

Merge pull request #5255 from tgtje/master

51d7875

Issue #6 Existing text to LAN's

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove and optimize (hardcoded) LANS #6

Remove and optimize (hardcoded) LANS #6

CaMer0n commented Nov 28, 2012

Moc commented Dec 28, 2019

CaMer0n commented Dec 28, 2019