Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum breadcrumbs on topic view with 3 forums #4286

Closed
Jimmi08 opened this issue Dec 7, 2020 · 5 comments · Fixed by #4710
Closed

Forum breadcrumbs on topic view with 3 forums #4286

Jimmi08 opened this issue Dec 7, 2020 · 5 comments · Fixed by #4710
Assignees
Labels
plugin: forum type: bug A problem that should not be happening
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Dec 7, 2020

Bug Description

Breadcrumbs on forum view page (used {BREADCRUMB} in forum template) are wrong in some case

normal case:
parent forum
forum
topic

  • breadcrumbs are correct.
  1. /forum
  2. /forum#parent forum
  3. /forum/forum-sef

Special case (nothing in admin stopped me to do this)
parent forum
subforum
forum
topic

  1. /forum
  2. /forum/parent-forum-sef - not #
  3. /forum/parent-forum-sef - not subforum
  4. /forum/forum-sef

I don't know how to fix this.
Thanks

@Jimmi08 Jimmi08 added the type: bug A problem that should not be happening label Dec 7, 2020
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 15, 2022

This is fixed in 2.3.1

@Jimmi08 Jimmi08 closed this as completed Mar 15, 2022
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 16, 2022

It is still there. I checked wrong page.

On view topic page with subforum, normal structure, just subforum:

image

breadcrumbs for subforum are correct

but on topic itself:
image

<ul class="breadcrumb">
<li class="breadcrumb-item"><a href="/e107-2_3_1_git/" aria-label="Homepage"><i class="fas fa-home"></i> </a></li>
<li class="breadcrumb-item"><a href="/e107-2_3_1_git/forum">Forums</a></li>
<li class="breadcrumb-item"><a href="/e107-2_3_1_git/forum#your-main-category-forum">Your Main Category Forum</a></li>
<li class="breadcrumb-item"><a href="/e107-2_3_1_git/forum/your-main-category-forum/">Your second forum</a></li>
<li class="breadcrumb-item"><a href="/e107-2_3_1_git/forum/second-forum-subforum/">Second forum - subforum</a></li>
<li class="breadcrumb-item">test</li>
</ul>

@Jimmi08 Jimmi08 reopened this Mar 16, 2022
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 21, 2022

this is fix:

image

@Moc
Copy link
Member

Moc commented Mar 21, 2022

@Jimmi08 welcome to submit as PR :)

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 25, 2022

It should solve this too:
#2565

CaMer0n added a commit that referenced this issue Mar 27, 2022
Fixes #4286 - Forum breadcrumbs on topic view with 3 forums
@CaMer0n CaMer0n added this to the e107 2.3.2 milestone Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: forum type: bug A problem that should not be happening
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants