Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online Languages packs not displaying in 2.3.0-rc1 #4229

Closed
Jimmi08 opened this issue Aug 17, 2020 · 11 comments
Closed

Online Languages packs not displaying in 2.3.0-rc1 #4229

Jimmi08 opened this issue Aug 17, 2020 · 11 comments
Assignees
Labels
type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Aug 17, 2020

Motivation

There are no languages packs listed for 2.3.0 version

image

Proposed Solution

  1. Add help for the correct name of the tag if you want to be listed in languages packs

  2. List all available packs, just latest tag,

Thanks

For actual version this doesn't work:
image
image
image

@Jimmi08 Jimmi08 added the type: enhancement An improvement or new feature request label Aug 17, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Aug 17, 2020

I just checked locally and on 2 production sites. The result is the same:

image

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Aug 17, 2020

@CaMer0n what is your e107 version? git? Or RC1?

I just updated 2.2.1 local version (with languages listed) to official RC1 release:

image

German lang was already installed:

image

@CaMer0n
Copy link
Member

CaMer0n commented Aug 17, 2020

Mine is Git. Try enabling DEBUG mode, does it help?
Maybe the "-rc1" is messing it up.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Aug 17, 2020

No change. I can see error:
Invalid argument supplied for foreach(), Line 383 of ***\e107_admin\language.php

@tgtje
Copy link
Contributor

tgtje commented Aug 18, 2020

Mine (live) does display the same as Cameron's (with name pre-release x2)
Same on local although my Dutch had the first 2.3.0 (dev version let's call it) does show available 2.3.0.pre-release

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Aug 18, 2020

Version 2.3.0-rc1

  • no lang packs

I tried to sync with github, I can see that admin/ver.php says 2.3.0 (git), but version wasn't changed.

I deleted pref version, run update, and e107 version is now 2.2.0

Lang packs are displayed for 2.2.0.

Then I synced again, and version was changed to 2.3.0 and lang packs are displayed.

So @tgtje check what is value of your version pref. I suppose you don't use official release. Next weird thing is that it didn't change version after sync from 2.3.0-rc1 to 2.3.0 git. But it did it after sync from 2.2.0.

@tgtje
Copy link
Contributor

tgtje commented Aug 18, 2020

@Jimmi08
2.3.0 (git) 5-5-2020 live
2.3.0 (git) 23-7-2020 local (one of the latest)
2.3.0 (git) 12-01-2020 local ) old one > also displays preleases
all are synced versions at the time

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Aug 18, 2020

@Jimmi08
2.3.0 (git) 5-5-2020 live
2.3.0 (git) 23-7-2020 local (one of the latest)
2.3.0 (git) 12-01-2020 local ) old one > also displays preleases
all are synced versions at the time

But I am testing official release pack, not developer version.

@tgtje
Copy link
Contributor

tgtje commented Aug 18, 2020

@Jimmi08 Got it, new install from official download.
In the off.version ver php has : $e107info['e107_version'] = "2.3.0-rc1"; > correct NO Lpacks after install

While git says $e107info['e107_version'] = "2.3.0 (git)"; (changed 1 month ago).

After changing the off ver php to $e107info['e107_version'] = "2.3.0 (git)"; All functions and language packs show up.
(to be sure i re-installed it with the changed ver php). tested on local.. (even used VPN).

@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Aug 19, 2020
@CaMer0n CaMer0n self-assigned this Aug 19, 2020
@CaMer0n CaMer0n added this to the e107 2.3.0 milestone Aug 19, 2020
@CaMer0n CaMer0n changed the title Do something with languages packs please Languages packs not displaying in 2.3.0-rc1 Aug 19, 2020
@CaMer0n CaMer0n changed the title Languages packs not displaying in 2.3.0-rc1 Online Languages packs not displaying in 2.3.0-rc1 Aug 19, 2020
CaMer0n added a commit that referenced this issue Aug 19, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Aug 19, 2020

@Jimmi08 Please replace the 2 files and close if fixed for you. Thanks

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Aug 19, 2020

Thank you. I will reopen it in the next attempt if needed.

@Jimmi08 Jimmi08 closed this as completed Aug 19, 2020
Reconix pushed a commit to Reconix/e107 that referenced this issue Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

3 participants