Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how to displaye custom values for boolean field in read mode and filter mode? #4086

Closed
Jimmi08 opened this issue Jan 30, 2020 · 3 comments
Closed

how to displaye custom values for boolean field in read mode and filter mode? #4086

Jimmi08 opened this issue Jan 30, 2020 · 3 comments
Assignees
@CaMer0n
Labels
core: Admin-UI type: bug A problem that should not be happening type: question An ask about behavior that is not found documented anywhere

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jan 30, 2020

#3652 Question

With custom values for Yes/No texts, they are correctly displayed in Write mode.

What is the correct settings to have it displayed with those value?

Now it looks like this,

		'readParms' => array ('enabled'=>'TÉMA', 'disabled'=>'ČLÁNOK'), 
		'writeParms' => array ('enabled'=>'TÉMA', 'disabled'=>'ČLÁNOK'),

With filter, there is still Yes/No
image

And with Read mode with inline editing:
image

With Read mode without inline editing:
image

Thanks
@Jimmi08 Jimmi08 added the type: question An ask about behavior that is not found documented anywhere label Jan 30, 2020
@CaMer0n CaMer0n self-assigned this Feb 20, 2020
@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Feb 20, 2020
CaMer0n added a commit that referenced this issue Feb 20, 2020
@CaMer0n
Issue #4086 Boolean admin-ui form element readParm/writeParm consiste…
ca61cd7 
…ncy.
@CaMer0n
Copy link
Member

CaMer0n commented Feb 20, 2020

@Jimmi08 I believe readParms() was using 'true'=>'custom' instead of 'enabled'='custom'.
This has been fixed, so that read/write Parms can use either enabled/disabled or true/false key values.

I will look into the 'filter' dropdown.

CaMer0n added a commit that referenced this issue Feb 20, 2020
@CaMer0n
Issue #4086 - admin-ui Respect boolean true/false writeParms in filte…
33a7685 
…r and batch dropdowns.
@CaMer0n
Copy link
Member

CaMer0n commented Feb 20, 2020

@Jimmi08 Please test it out and let me know. Thank you.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Feb 22, 2020

Thank you, tested, filter, inline edit mode work.

@Jimmi08 Jimmi08 closed this as completed Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaMer0n CaMer0n

Labels
core: Admin-UI type: bug A problem that should not be happening type: question An ask about behavior that is not found documented anywhere
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Moc @CaMer0n @Jimmi08