Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q - was something changed how e_admin works? #3695

Closed
Jimmi08 opened this issue Feb 26, 2019 · 7 comments
Closed

Q - was something changed how e_admin works? #3695

Jimmi08 opened this issue Feb 26, 2019 · 7 comments
Assignees
Labels
type: bug A problem that should not be happening type: enhancement An improvement or new feature request type: question An ask about behavior that is not found documented anywhere

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Feb 26, 2019

I have the plugin that extends pages. It worked without problems some time already.

  • tab is correctly displayed
  • value is correctly rendered

image

But those fields can be displayed in listing form too now
image
but the value is not rendered correctly.
image

I checked _blank plugin, there is nothing about READ mode or how to not display those field on options.

@Moc Moc added the type: question An ask about behavior that is not found documented anywhere label Feb 26, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Feb 28, 2019

@Jimmi08 Is my simple canonical plugin still working for you? Nothing has changed as far as I now. Has your PHP version changed?

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Feb 28, 2019

@CaMer0n
the same with your canonical plugin - tested with news
image

then I tried Reference plugin and the same problem
image

Now tested with php 7.2 , but original problem was with 5.6.

@CaMer0n
Copy link
Member

CaMer0n commented Feb 28, 2019

@Jimmi08 Okay. Thank you!

@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Feb 28, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Mar 2, 2019

@Jimmi08 Did it work in 2.1.9 ?

@CaMer0n CaMer0n closed this as completed in 4e07b87 Mar 3, 2019
@CaMer0n CaMer0n added the type: enhancement An improvement or new feature request label Mar 3, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Mar 3, 2019

@Jimmi08 To summarize: The listing aspect of the e_admin addon was never implemented. This has now been added in the last commit. Please see the canonical plugin for a working example. (or _blank)
btw. I don't foresee support for inline editing being added any time soon.

image

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 4, 2019

@CaMer0n Thank you very much. I am sorry, but I didn't ask to add listing mode at all. What was changed was adding those fields to option values (and so the ability to display them).

@CaMer0n
Copy link
Member

CaMer0n commented Mar 4, 2019

@Jimmi08 I have just updated e107's core again and updated the reference plugin. Custom 'read' method is now supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening type: enhancement An improvement or new feature request type: question An ask about behavior that is not found documented anywhere
Projects
None yet
Development

No branches or pull requests

3 participants