Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php 7 compatibility - preg_replace() with /e #3216

Closed
Jimmi08 opened this issue Jun 25, 2018 · 3 comments
Closed

php 7 compatibility - preg_replace() with /e #3216

Jimmi08 opened this issue Jun 25, 2018 · 3 comments
Assignees
@CaMer0n
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening
Milestone
e107 2.2.0

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 25, 2018 •
edited by Moc
Loading

The reason:

$textstring .= preg_replace("/\{(.*?)\}/e", '$\1', $ONLINE_TABLE);

preg_replace(): The /e modifier is no longer supported” error in PHP7
@Moc Moc added this to the e107 2.1.9 milestone Jun 25, 2018
@Moc Moc added the type: bug A problem that should not be happening label Jun 25, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.9, e107 2.2.0 Aug 22, 2018
@Jimmi08 Jimmi08 mentioned this issue Nov 28, 2018
Closed
@CaMer0n CaMer0n changed the title online.php doesn't work with php 7 php 7 compatibility - preg_replace() with /e Jan 15, 2019
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jan 15, 2019

But they can be uncommented...
image

@CaMer0n CaMer0n added the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Jan 15, 2019
CaMer0n added a commit that referenced this issue Jan 15, 2019
@CaMer0n
Issue #3216 PHP 7 compatibility
9fc5d9e
@CaMer0n CaMer0n self-assigned this Jan 16, 2019
CaMer0n added a commit that referenced this issue Jan 17, 2019
@CaMer0n
Issue #3216 PHP 7
68a4aae
CaMer0n added a commit that referenced this issue Jan 17, 2019
@CaMer0n
Issue #3216 PHP7 Fixes.
221f120
@CaMer0n
Copy link
Member

CaMer0n commented Jan 17, 2019

@Jimmi08 I haven't found any others. A lot of the files you have listed have already been corrected. The code you found exists as comments only.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jan 17, 2019

@CaMer0n Yes, it's possible, I didn't check them then. Thank you.

@Jimmi08 Jimmi08 closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaMer0n CaMer0n

Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. type: bug A problem that should not be happening
Projects
None yet
Milestone
e107 2.2.0
Development

No branches or pull requests
3 participants
@Moc @CaMer0n @Jimmi08