Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Forum Posts plugin : excerpt not shown and author infos incorrect #3132

Closed
pierre0042 opened this issue May 16, 2018 · 17 comments
Closed
Labels
plugin: forum type: bug A problem that should not be happening
Milestone

Comments

@pierre0042
Copy link

pierre0042 commented May 16, 2018

Hi, after an upgrade on Github last sources, the New Forum Posts plugin doesn't display anymore the excerpt of the forum posts, and shows "48 years ago" instead of the username.

The forum is still working properly.

ss-plugin

("derniers sujets" means "last topics" in french FYI)

@CaMer0n
Copy link
Member

CaMer0n commented Jun 6, 2018

@pierre0042 Try using the new forum posts menu which is part of the 'news' plugin.

@pierre0042
Copy link
Author

I can't find it, are you sure about the name?

@Moc
Copy link
Member

Moc commented Jun 23, 2018

Confirmed as a bug. This issue occurs with the default newforumposts_menu (forum) menu, part of the forum plugin.

There is another newforumposts menu in it's own folder e107_plugins/newforumposts_main which is not recognized by the menu manager as a menu, but instead is used by older themes or plugins by calling the shortcode { NEWFORUMPOSTS}

@Moc Moc added the type: bug A problem that should not be happening label Jun 23, 2018
@Moc Moc added this to the e107 2.1.8 milestone Jun 23, 2018
@SimSync
Copy link
Contributor

SimSync commented Jun 24, 2018

@pierre0042 This is happens if the options for this menu haven't been touched after adding the menu to the menuarea. Due to that, the wrong query is executed and the menu is "empty".
I'll add a fix for the wrong query...

@Moc
Copy link
Member

Moc commented Jun 26, 2018

#3040

@Moc Moc closed this as completed in d1a90cb Jun 26, 2018
Moc added a commit that referenced this issue Jun 26, 2018
Fixes #3132 after adding the menu to the menu area, the wrong
@pierre0042
Copy link
Author

I updated my version. The author information is now correct, but the excerpt is still not displayed.

@Moc Moc reopened this Jun 26, 2018
@Moc
Copy link
Member

Moc commented Jun 26, 2018

Yeah.... these forum shortcodes are a mess. Looking into it.

@Moc Moc modified the milestones: e107 2.1.8, e107 2.1.9 Jun 26, 2018
@pierre0042
Copy link
Author

Now the plugin title isn't displayed correctly as well

screenshot

@SimSync
Copy link
Contributor

SimSync commented Jun 26, 2018

@pierre0042 Please check in the menu settings which layout is used and also try the other layouts.

@pierre0042
Copy link
Author

It is set to "Default"

@SimSync
Copy link
Contributor

SimSync commented Jun 26, 2018

Did you test the other layouts?

@pierre0042
Copy link
Author

Yes, it's not better. There are "Minimal" and "Main".
Main tries to display the whole forum in the small box...

Minimal looks like this :
screenshot2

@SimSync
Copy link
Contributor

SimSync commented Jun 26, 2018

Ok, I'll look after it.

@SimSync
Copy link
Contributor

SimSync commented Jun 26, 2018

Just submitted a pull request, which should fix both issues: The missing excerpt and the malformed caption.

@Moc Moc closed this as completed in bd02bd2 Jun 27, 2018
Moc added a commit that referenced this issue Jun 27, 2018
Fixes #3132 Fixes issue with new forum posts menu
@Moc Moc reopened this Jun 27, 2018
@Moc
Copy link
Member

Moc commented Jun 27, 2018

Thanks @SimSync!
I think there will still be an issue with the actual excerpt not showing... Testing now.

@Moc Moc closed this as completed Jun 27, 2018
@Moc
Copy link
Member

Moc commented Jun 27, 2018

All fixed for me.
@pierre0042 Can you confirm it's working? :)

@pierre0042
Copy link
Author

I confirm. Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: forum type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

4 participants