Sep 2024 Fixes #1181
Merged
Sep 2024 Fixes #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I attempted to unify the appearance of the statusbar between platforms by adding the StatusBar plugin (which had already been referenced in the code). However, this caused major issues on some Android devices with the entire appbar no longer being visible. This was not a high priority; rather than spend a lot of time trying to get the right appearance, I am just going to revert it for now
This allows formatForDisplay to determine digits appropriately (e.g. instead of 300.1, just shows 300)
using isoDatesDifference here (which wraps Luxon's diff) yields decimal values when a full datetime string is provided. If on the same day we are expecting the diff to be 0 (falsy) but get 0.2 or similar (truthy) All we actually need here is to know if the start and end fall on different dates, so we can simply take the YYYY-MM-DD part of the strings and test for string equality KISS
uses e-mission-common's scale_lightness and dedupe_colors, so no longer need darkenOrLighten and dedupColors Also remove getMeteredBackgroundColor and createDiagonalPattern which were both unused
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
==========================================
+ Coverage 28.83% 29.12% +0.29%
==========================================
Files 122 122
Lines 5012 4961 -51
Branches 1145 1129 -16
==========================================
Hits 1445 1445
+ Misses 3565 3514 -51
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shankari
approved these changes
Sep 27, 2024
| } | ||
| // //fill pattern creation | ||
| // //https://stackoverflow.com/questions/28569667/fill-chart-js-bar-chart-with-diagonal-stripes-or-other-patterns | ||
| // function createDiagonalPattern(color = 'black') { |
There was a problem hiding this comment.
nit: why is this commented out? will it be restored or removed in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove StatusBar plugin
I attempted to unify the appearance of the statusbar between platforms by adding the StatusBar plugin (which had already been referenced in the code).
However, this caused major issues on some Android devices with the entire appbar no longer being visible.
This was not a high priority; rather than spend a lot of time trying to get the right appearance, I am just going to revert it for now
Don't override fraction digits on SummaryCard
This allows formatForDisplay to determine digits appropriately (e.g. instead of 300.1, just shows 300)
fix redundant dates showing on Label tab
using isoDatesDifference here (which wraps Luxon's diff) yields decimal values when a full datetime string is provided. If on the same day we are expecting the diff to be 0 (falsy) but get 0.2 or similar (truthy)
All we actually need here is to know if the start and end fall on different dates, so we can simply take the YYYY-MM-DD part of the strings and test for string equality
KISS
charting: use emcommon color fns; remove unused fns
uses e-mission-common's scale_lightness and dedupe_colors, so no longer need darkenOrLighten and dedupColors
Also remove getMeteredBackgroundColor and createDiagonalPattern which were both unused
Fix typo "SumaryCard"
rename util -> datetimeUtil