Add vlan_id and role_id for netbox_prefix resource
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbreckle Would you plan to create a new release? When? |
|
Please add the new attributes to the tests, too. I did not yet make a new release yet, because you mentioned, that you want to add vlan_id and role_id (i.e. this MR). Will release after merging this. |
Sanverik
force-pushed
the
add-new-attributes
branch
from
9d076e4
to
40657de
Compare
I meant add |
# Conflicts: # netbox/provider.go
Sanverik
force-pushed
the
add-new-attributes
branch
from
7454208
to
cbb5004
Compare
|
@fbreckle please, review. Thank you in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.