Add VRF data source and support for vrf_id in netbox_ip_address res… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I got some of the tests wrong (I specified netbox_vrf as a resource, not data source)... I'm developing on WSL1 so looks like I'll need get my environment setup for Docker so I can run "testacc" locally. |
rthomson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new "netbox_vrf" data source and support for "vrf_id" in the "netbox_ip_address" resource.
The data source allows for looking up vrf_id by name, which can then be passed to a "netbox_ip_address" resource in order to support linking an IP to a VRF in netbox.
I'm definitely not a golang developer (first timer!) so I just used the existing data sources and resources from this project as a reference guide/template. Also, I really have no clue if I got the tests right but "make test" doesn't seem to complain.