Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Add tenant_group to netbox_tenants datasource #129

Merged

Conversation

twink0r
Copy link
Contributor

@twink0r twink0r commented Mar 1, 2022

No description provided.

netbox/data_source_netbox_tenants.go Outdated Show resolved Hide resolved
netbox/data_source_netbox_tenants.go Outdated Show resolved Hide resolved
netbox/data_source_netbox_tenants.go Outdated Show resolved Hide resolved
netbox/data_source_netbox_tenants.go Outdated Show resolved Hide resolved
@fbreckle
Copy link
Collaborator

fbreckle commented Mar 2, 2022

Needs some tests!

@fbreckle
Copy link
Collaborator

fbreckle commented Mar 2, 2022

@twink0r
Copy link
Contributor Author

twink0r commented Mar 2, 2022

I deleted the message because I checked the documentation and not check the source

@twink0r
Copy link
Contributor Author

twink0r commented Mar 3, 2022

@fbreckle tests added and typos fixed

@twink0r twink0r force-pushed the add-tenant-groups-to-tenants-datasource branch from c406e9e to 3d6be6b Compare March 4, 2022 05:15
@twink0r
Copy link
Contributor Author

twink0r commented Mar 4, 2022

@fbreckle test is renamed!

Copy link
Collaborator

@fbreckle fbreckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some indentation, then we're good to go

netbox/data_source_netbox_tenants_test.go Show resolved Hide resolved
netbox/data_source_netbox_tenants_test.go Show resolved Hide resolved
@fbreckle fbreckle merged commit 655c37c into e-breuninger:master Mar 4, 2022
@fbreckle
Copy link
Collaborator

fbreckle commented Mar 4, 2022

For reference: c3cfc40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants