generated from hashicorp/terraform-provider-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Add tenant_group to netbox_tenants datasource #129
Merged
fbreckle
merged 3 commits into
e-breuninger:master
from
twink0r:add-tenant-groups-to-tenants-datasource
Mar 4, 2022
Merged
🔨 Add tenant_group to netbox_tenants datasource #129
fbreckle
merged 3 commits into
e-breuninger:master
from
twink0r:add-tenant-groups-to-tenants-datasource
Mar 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbreckle
reviewed
Mar 2, 2022
Needs some tests! |
Not sure I follow, since we have |
I deleted the message because I checked the documentation and not check the source |
@fbreckle tests added and typos fixed |
fbreckle
reviewed
Mar 3, 2022
twink0r
force-pushed
the
add-tenant-groups-to-tenants-datasource
branch
from
March 4, 2022 05:15
c406e9e
to
3d6be6b
Compare
@fbreckle test is renamed! |
fbreckle
reviewed
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some indentation, then we're good to go
For reference: c3cfc40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.