-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to Nibbels 1.5.2 #1
Conversation
Youtube multibyte fix
Multibyte and strpos fixes
https://github.com/DjazzLab/ocdownloader/issues/44 Todo: Discuss where the rescan function has to be hooked in. I just hooked it to a visit of "all files" and "completed files" for now.
I tested on 11 only.
it was pulled because of the commit 1.5 over 1.51
Thanks for you effort. I will take a look into it and then merge it. |
I took a look into it and saw that you added a few of the commits back from after the license change to CC-BY-SA. Could you modify your PR to only contain your own changes in a single commit? That way I can do a clean merge without facing the license problem again, because the current one includes @djazzlab 's and @Loki3000 's changes from after the licence change. |
… license second try
The license should have been cleaned out now :) |
I tested the HTTP-download with nextcloud 12.0.2 I did not test all the other download functions. |
I incorporated your changes manually to preserve a clean commit history. Thanks for your work, I pushed it already mentioning you in the Readme file for helping out. Next step would be to push it to the Nextcloud store. |
I guess it is now the time to clean up my repositories and to refork your branch :) |
fix issue with breakage in OC 17-18 due to change of group admin.
Merge pull request #21 from Loki3000/master
I downloaded your branch, changed it manually according to my changes and according to the changes of Loki3000/Djazz.
Then uploaded it as a new branch on my fork.
This new fork is now the main fork "e-alfred-master".
That is
#Nibbels | Moving to e-alfred/ocdownloader for further development …| ac33228
#Nibbels | dont need that file for this new branch …| e6c9171
Whatever history github keeps, it is because of my "Upload Files"-Action to the original master branch.
I dont relly know about those license-changes. I just left those out in the process.
If I have to undo all the fixes Loki3000 and DjassLab did to the branch tell me! Couldnt refork yours, because I didnt want to delete DjassLabs master. Tell me if I have to!