cppcheck with --project

CI: test misra with RELEASE=1
Generates compile db without ALLOW_DEBUG

.github/workflows/test.yaml

@@ -96,9 +96,12 @@ jobs:
         run: eval "$BUILD"
       - name: Build FW
         run: ${{ env.RUN }} "scons -j$(nproc)"
-      - name: Run MISRA C:2012 analysis
+      - name: Run MISRA C:2012 analysis - ALLOW_DEBUG
         timeout-minutes: 1
         run: ${{ env.RUN }} "cd tests/misra && ./test_misra.sh"
+      - name: Run MISRA C:2012 analysis - RELEASE
+        timeout-minutes: 2
+        run: ${{ env.RUN }} "cd tests/misra && CERT=./certs/debug RELEASE=1 ./test_misra.sh"
       - name: MISRA mutation tests
         timeout-minutes: 7
         run: ${{ env.RUN }} "cd tests/misra && pytest -n8 test_mutation.py"

.gitignore

@@ -20,6 +20,7 @@ examples/output.csv
 nosetests.xml
 .mypy_cache/
 .sconsign.dblite
+compile_commands*.json
 
 # CTU info files generated by Cppcheck
 *.*.ctu-info

SConscript

@@ -107,8 +107,8 @@ def build_project(project_name, project, extra_flags):
 
   # Bootstub
   crypto_obj = [
-    env.Object(f"rsa-{project_name}", f"{panda_root}/crypto/rsa.c"),
-    env.Object(f"sha-{project_name}", f"{panda_root}/crypto/sha.c")
+    env.Object(f"bootstub-rsa-{project_name}", f"{panda_root}/crypto/rsa.c"),
+    env.Object(f"bootstub-sha-{project_name}", f"{panda_root}/crypto/sha.c")
   ]
   bootstub_obj = env.Object(f"bootstub-{project_name}", File(project.get("BOOTSTUB", f"{panda_root}/board/bootstub.c")))
   bootstub_elf = env.Program(f"obj/bootstub.{project_name}.elf",

SConstruct

@@ -22,7 +22,13 @@ env = Environment(
 )
 
 if GetOption('compile_db'):
+    # whole project compilation database
     env.CompilationDatabase("compile_commands.json")
 
+    # Panda compilation database
+    env_p = env.Clone()
+    env_p["COMPILATIONDB_PATH_FILTER"] = '*board/[!jungle/][!bootstub]*'
+    env_p.CompilationDatabase("compile_commands_panda.json")
+
 # panda fw & test files
 SConscript('SConscript')

tests/misra/panda_macro_config.h

@@ -1,5 +1,5 @@
-// This is a dummy structure to allow cppcheck to test certain macro combinations 
-// together and in one seesion (needed for things like unused macros) 
+// This is a dummy structure to allow cppcheck to test certain macro combinations
+// together and in one seesion (needed for things like unused macros)
 // The structure should represents macro configurations used in scons
 
 #ifdef STM32H7
@@ -12,5 +12,4 @@
     #ifdef ENABLE_SPI
     #endif
   #endif
-#else
 #endif

tests/misra/test_misra.sh

@@ -28,7 +28,7 @@ fi
 
 cd $PANDA_DIR
 if [ -z "${SKIP_BUILD}" ]; then
-  scons -j8
+  scons -j8 --compile_db
 fi
 
 CHECKLIST=$DIR/checkers.txt
@@ -61,6 +61,7 @@ cppcheck() {
   fi
 }
 
+# *** Legacy cppcheck test type by providing c files list ***
 # --force checks different macro combinations to avoid reporting macros and functions used by only one panda configuration
 # panda_macro_config.h lets cppcheck know macro combinations used for the build
 printf "\n${GREEN}** Panda tests: cppcheck whole program anlysis + Misra addon system level analysis **${NC}\n"
@@ -72,6 +73,25 @@ cppcheck  $PANDA_DIR/board/main.c -I$PANDA_DIR/board/ \
           --include=$DIR/panda_macro_config.h -i$DIR \
           --enable=all --addon=misra \
           --force --suppress=unknownMacro
+# TODO remove this test when cppcheck supports system level misra reporting with --project
+
+if [ -z "$PANDA_SYSTEM_LEVEL_ONLY" ]; then
+# Test standalone Panda program. (Unused functions more strict than whole project check)
+  printf "\n${GREEN}** Panda standalone - tests: Cppcheck whole program **${NC}\n"
+  cppcheck  --project=$PANDA_DIR/compile_commands_panda.json \
+            --enable=all
+            # TODO add --addon=misra when cppcheck supports system level misra reporting with --project
+
+# Test whole Panda project for unused functions
+printf "\n${GREEN}** Panda project - tests: Cppcheck whole program + MISRA per translation unit **${NC}\n"
+cppcheck  --project=$PANDA_DIR/compile_commands.json \
+          --enable=all --addon=misra --disable=unusedFunction \
+          -i$PANDA_DIR/board/bootstub.c \
+          -i$PANDA_DIR/board/jungle/ \
+          -i$PANDA_DIR/crypto/
+# TODO enable bootstub and jungle for the whole build
+# Note: MISRA system level tests (e.g. rule 2.5) not supported by cppcheck 2.14.1 with --project argument
+fi
 printf "\n${GREEN}Success!${NC} took $SECONDS seconds\n"
 
 

tests/misra/test_mutation.py

@@ -81,6 +81,6 @@ def test_misra_mutation(fn, patch, should_fail, tmp_path):
     assert r == 0
 
   # run test
-  r = subprocess.run("SKIP_TABLES_DIFF=1 tests/misra/test_misra.sh", cwd=tmp_path, shell=True)
+  r = subprocess.run("SKIP_TABLES_DIFF=1 PANDA_SYSTEM_LEVEL_ONLY=1 tests/misra/test_misra.sh", cwd=tmp_path, shell=True)
   failed = r.returncode != 0
   assert failed == should_fail