#3214: new field approved usage #3275
Conversation
…t into ewolf47/issue3214
…vocabulary) field (approved-usage-list --> separate filter)
| return "data-package-management.common.approvedUsage.nonCommercialUse" | ||
| case 'COMMERCIAL_USE': | ||
| return "data-package-management.common.approvedUsage.commercialUse" | ||
| } |
There was a problem hiding this comment.
bräuchte es hier noch einen default case mit einem console log?
There was a problem hiding this comment.
ich bau es mal mit mein. Aber prinzipiell können hier eigentlich nur die Fälle auftreten, die hier definiert sind.
| case 'NON_COMMERCIAL_USE': | ||
| return "data-package-management.common.approvedUsage.nonCommercialUse" | ||
| case 'COMMERCIAL_USE': | ||
| return "data-package-management.common.approvedUsage.commercialUse" |
| md-floating-label="{{'data-package-management.detail.label.approvedUsage' | translate}}" | ||
| md-input-maxlength="512" | ||
| md-input-name="approvedUsage" | ||
| md-is-error="!dataPackageForm.approvedUsage.$valid && (dataPackageForm.approvedUsage.$dirty dataPackageForm.approvedUsage.$touched) " |
There was a problem hiding this comment.
hier fehlt noch ein Operator? bspw. OR
| md-is-error="!dataPackageForm.approvedUsage.$valid && (dataPackageForm.approvedUsage.$dirty dataPackageForm.approvedUsage.$touched) " | |
| md-is-error="!dataPackageForm.approvedUsage.$valid && (dataPackageForm.approvedUsage.$dirty || dataPackageForm.approvedUsage.$touched) " |
| md-floating-label="{{'data-package-management.detail.label.approvedUsage' | translate}}" | ||
| md-input-maxlength="512" | ||
| md-input-name="approvedUsage" | ||
| md-is-error="!dataPackageForm.approvedUsage.$valid && (dataPackageForm.approvedUsage.$dirty dataPackageForm.approvedUsage.$touched) " |
| @@ -197,7 +200,9 @@ angular.module('metadatamanagementApp').config([ | |||
| 'study-series': 'By which study series do you want to filter?', | |||
| 'institution': 'By which institute do you want to filter?', | |||
| 'sponsor': 'By which sponsor do you want to filter?', | |||
| 'survey-method': 'By which survey method do you want to filter?' | |||
| 'survey-method': 'By which survey method do you want to filter?', | |||
| 'approved-usage': 'By which special restrictions for the data use do you want to filter?', | |||
There was a problem hiding this comment.
Bin mir bei dieser Englischen Übersetzung nicht sicher...vielleicht According to which special restrictions for the data use would you like to filter? oder What specific data usage restrictions would you like to filter by?; 'approved-usage-list' analog
There was a problem hiding this comment.
ich habe mich hier an den anderen labels orientiert. Die sind alle nach dem Schema:
"By which <filter type> do you want to filter?"
Würde es daher mal so lassen.
A new filed has been added to the datapacke form and detail page. The new field was also added to the filter