Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: localization cleanup #409

Merged

Conversation

ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Oct 23, 2021

Description

Fixed linting/typing issues for #24 code

  • TS Types errors.
  • Change the interface of Language from string to Object
  • updated Endpoints interface to adapt to the new localization changes
  • fixed bug where requesting default language causes ./api to return 500

Type of change

  • Refactoring

@ZibanPirate ZibanPirate self-assigned this Oct 23, 2021
@github-actions github-actions bot added common Common related changes ( common folder ) mobile Mobile related changes ( mobile folder ) web Web related changes ( web folder ) labels Oct 23, 2021
@ZibanPirate ZibanPirate requested a review from a team October 23, 2021 09:19
@ZibanPirate ZibanPirate force-pushed the chore/localization-cleanup-23th-october branch from 159e246 to 820ea9b Compare October 23, 2021 15:37
@ZibanPirate ZibanPirate merged commit c68a93f into feat/localization Oct 24, 2021
@ZibanPirate ZibanPirate deleted the chore/localization-cleanup-23th-october branch October 24, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Common related changes ( common folder ) mobile Mobile related changes ( mobile folder ) web Web related changes ( web folder )
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants