Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to mpv_config-2025.01.01 #166

Merged
merged 1 commit into from
Jan 18, 2025
Merged

update to mpv_config-2025.01.01 #166

merged 1 commit into from
Jan 18, 2025

Conversation

IPeTeXI
Copy link

@IPeTeXI IPeTeXI commented Jan 16, 2025

This is my first pull request and translation. I have never done anything like this before. So, if I have done something wrong, please forgive me. Feel free to point it out to me and I'll try to correct the mistakes. I would also be very happy if other people could help to translate regularly so that we can all benefit from @dyphire 's great configuration. 😊

PS: Chinese and English are not my native languages.

@dyphire dyphire self-requested a review January 18, 2025 13:28
Copy link
Owner

@dyphire dyphire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it's a bit late, LGTM.
Good job, thank you for your efforts.

@dyphire dyphire merged commit febeb61 into dyphire:eng Jan 18, 2025
@IPeTeXI
Copy link
Author

IPeTeXI commented Jan 18, 2025

Thanks, I'm currently working on a better version. Which has better formatting and spelling but it needs some more time.

@dyphire
Copy link
Owner

dyphire commented Jan 18, 2025

Thanks, I'm currently working on a better version. Which has better formatting and spelling but it needs some more time.

That would be great.

@Zabooby
Copy link

Zabooby commented Jan 24, 2025

I would also be very happy if other people could help to translate regularly so that we can all benefit from @dyphire 's great configuration. 😊

What method did you use to translate, if it isn't too time consuming I can help out in the future?

@IPeTeXI
Copy link
Author

IPeTeXI commented Jan 24, 2025

To get good results, I translated everything manually with multiple translators with the help of a browser extension called Immersion Translation, because I got bad results otherwise, like loosing all the formatting, breaking Lua scripts etc. So it really is a big effort and time-consuming.

@Zabooby
Copy link

Zabooby commented Jan 24, 2025

I actually did the previous translation for the english branch and I used ChatGPT. I had pretty good results with the right prompts. Could you try translating a conf file and see how it compares to your experience?

@IPeTeXI
Copy link
Author

IPeTeXI commented Jan 24, 2025

I thought about doing the same, but decided against it. Because I do not trust ChatGPT that it always keeps the original code structure even if I tell it to, with the right prompt. I would have to verify line by line manually if it did. (even more effort)

In my opinion, my manual translation method is more reliable, except spelling and sometimes choosing the right words. (quick and easy to fix) We can keep the effort low, if we stay up to date with recent changes. What I will do for now, is to wait for the next config release and see how much changed.

Thank you for your previous efforts, btw! 😄

@Zabooby
Copy link

Zabooby commented Jan 25, 2025

Yeah that did happen a few times, for the highest accuracy your method is probably better.

I'll also keep an eye on releases, let me know if you need any help for future updates. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants