Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clipboard): fix wlclipboard on non-GNOME environments #640

Merged
merged 2 commits into from
May 8, 2024

Conversation

Scrumplex
Copy link
Contributor

@Scrumplex Scrumplex commented May 8, 2024

gnome_version is empty on my system so parsing the integer in the subsequent line would raise an error.

Introduced by 6b6e351

@Scrumplex Scrumplex force-pushed the fix/clipboard/gnome-version branch from bd78552 to ea24151 Compare May 8, 2024 08:58
gnome_version is empty on my system so parsing the integer in the
subsequent line would raise an error.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex force-pushed the fix/clipboard/gnome-version branch from ea24151 to c0eb4ba Compare May 8, 2024 08:58
Copy link
Owner

@dynobo dynobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this error, too, and what a nice surprise: there is already a PR to fix it! Thanks a lot!

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.911% (-0.02%) from 84.93%
when pulling ea31d46 on Scrumplex:fix/clipboard/gnome-version
into 288c2dd on dynobo:main.

@dynobo dynobo merged commit a5fb478 into dynobo:main May 8, 2024
25 checks passed
@Scrumplex Scrumplex deleted the fix/clipboard/gnome-version branch May 8, 2024 12:41
@Scrumplex Scrumplex restored the fix/clipboard/gnome-version branch May 8, 2024 12:41
@Scrumplex Scrumplex deleted the fix/clipboard/gnome-version branch May 8, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants