Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle BaseWindow.hideEvent exception for non-macOS systems #138

Closed
wants to merge 1 commit into from

Conversation

erfan-khadem
Copy link

I was experiencing the following exception on my Arch setup using GNOME 40:

15:57:14 - INFO    - normcap.app            - L:37  - Starting Normcap v0.2.5
15:57:15 - INFO    - normcap.utils          - L:178 - Searching tesseract languages 
15:57:19 - ERROR   - normcap.utils          - L:288 - Uncaught exception! Quitting NormCap!
Traceback (most recent call last):
  File "/home/erfan/.local/lib/python3.9/site-packages/normcap/gui/base_window.py", line 201, in hideEvent
    if self.macos_border_window:
AttributeError: 'MainWindow' object has no attribute 'macos_border_window'

It turns out that by just returning and doing nothing at BaseWindow.hideEvent everything goes right; so I added this exception catching clause.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dynobo
Copy link
Owner

dynobo commented Aug 24, 2021

Your PR is highly appreciated, @er888kh. But I already solved this during refactoring which I committed some days ago to dev. The new release should be ready in a few days, if nothing pops up during testing.

@dynobo dynobo closed this Aug 24, 2021
@erfan-khadem
Copy link
Author

But I already solved this during refactoring

That is awesome! Thank you.

@erfan-khadem erfan-khadem deleted the patch-1 branch August 28, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants