Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optim/ci #531

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Optim/ci #531

merged 3 commits into from
Aug 5, 2024

Conversation

Narrat
Copy link
Collaborator

@Narrat Narrat commented Aug 1, 2024

While adding argon2 to workflow file I noticed some details

  1. folder portable got moved
  2. the tests for pbkdf2 should maybe be run before using them with the tomb tests

Narrat added 2 commits August 1, 2024 18:14
Before executing the main tests for tomb it should be checked if the
binaries for the pbkdf2 test are working like expected.
@Narrat Narrat changed the title jjOptim/ci Optim/ci Aug 1, 2024
@Narrat
Copy link
Collaborator Author

Narrat commented Aug 1, 2024

Or the workflow for the portable should be dropped entirely

@jaromil
Copy link
Member

jaromil commented Aug 1, 2024

We can archive the workflow of portable rewrite in its extras folder. I lost interest in completing it, seems noone is really interested. I'll simply make sure that the tomb script works on busybox.

@Narrat
Copy link
Collaborator Author

Narrat commented Aug 1, 2024

Alright. Will move the file

@jaromil jaromil merged commit 75aafc0 into dyne:master Aug 5, 2024
2 checks passed
@Narrat Narrat deleted the optim/ci branch August 5, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants