Fixed tomb listing failure message: localization friendly #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of PR #506: it had conflicts that I didn't know how to resolve, so I did it again.
1. Tomb Listing issue
When listing tombs with
tomb list
, if there are no tombs open, this failure message is shown:Line 2668:
The problem is that the
::1 status::
is alwaysopen
. So the message shown will be always:But the word
open
cannot be translated because it is a variable. In other languages, it sounds bad.The phrase
I can't see any open tomb, may they all rest in peace.
is used twice along tomb script, in lines 2832 (index_tombs
) and 2946 (search_tombs
). So we can safely adopt this phrase also forlist_tombs
in line 2668.2. Update POT and translation PO files
About this, @jaromil said:
Yes, you're right! I will update the POT. This also raises other questions though.
As I explained in extras / translations / README ALL
.po
files are outdated (except pt_BR-2.10.po). They are for Tomb 2.3 not 2.10+. I created thattomb-2.10.pot
for this reason in a very old PR already merged if you remember, but the oldtomb.pot
(for v2.3) was not deleted. I think we should delete that one too, and rename thetomb-2.10.pot
to justtomb.pot
. Will be a good idea to update the translation PO files with the new version, so translators can choose to update what is needed: