Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

Update SDK to latest version #22

Merged
merged 13 commits into from
Mar 30, 2022
Merged

Update SDK to latest version #22

merged 13 commits into from
Mar 30, 2022

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Mar 2, 2022

This PR updates the SDK version to the latest version.

@pichlermarc pichlermarc marked this pull request as ready for review March 11, 2022 17:14
Copy link
Member

@pirgeo pirgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the Python SDK has much more clarity now. Looks good, just a few questions/nits

example/basic_example.py Show resolved Hide resolved
example/basic_example.py Show resolved Hide resolved
test/test_exporter.py Outdated Show resolved Hide resolved
test/test_exporter.py Show resolved Hide resolved
test/test_exporter.py Outdated Show resolved Hide resolved
example/basic_example.py Outdated Show resolved Hide resolved
example/basic_example.py Outdated Show resolved Hide resolved
example/basic_example.py Show resolved Hide resolved
test/test_exporter.py Outdated Show resolved Hide resolved
test/test_exporter.py Outdated Show resolved Hide resolved
Copy link
Member

@pirgeo pirgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found a small bug in the example and some unused imports, otherwise looks good to me!

example/basic_example.py Outdated Show resolved Hide resolved
example/basic_example.py Outdated Show resolved Hide resolved
example/basic_example.py Outdated Show resolved Hide resolved
@pichlermarc pichlermarc merged commit 0ab4c61 into main Mar 30, 2022
@pichlermarc pichlermarc deleted the use-otel-metrics-v0.28b1 branch March 30, 2022 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants