Fix build on Windows by adding explicit type annotations

[ermin-muratovic]

I have added explicit type annotations where they were missing and breaking the build. For details see issue #343

[dynatrace-cla-bot]

All committers have signed the CLA.

[thomaspink]

LGTM. Please reword commit message:

• Should have type build instead of fix
• Remove issue number: The brackets should hold the scope (e.g. button) not the issue number. You can remove the scope in your case as it is optional. If you want to provide the issue number, please move it to the body (when using words like Fixes, or Solves right before the issue number you can autoclose the issue when the pr is merged)
• Would reword to something Fixes build on Windows by adding explicit type annotations

[ermin-muratovic]

Thank you @thomaspink for the suggestions. I hope I did the rebase correctly. I updated the commit message to your suggestion with Fixes and the issue number to autoclose the issue.

[lukasholzer]

LGTM: @ffriedl89 but we should investigate the root cause while the type inference is not working on windows. In case it is working on macOS.

[thomaspink]

@ermin-muratovic one small issue left, please move the issue number to the body/footer

build: Fixes build on Windows by adding explicit type annotations.

Closes #343

I updated the commit message guidelines to make it more clearer: #345 345

[ermin-muratovic]

LGTM: @ffriedl89 but we should investigate the root cause while the type inference is not working on windows. In case it is working on macOS.

@lukasholzer
The root cause seems to be an issue with importHelpers and when the @types directory is a symlink on windows. So maybe it is a file system issue (NTFS on Windows) and that is why it is working fine on Mac and Ubuntu. See also importHelpers with symlinks breaks type resolution #29221.

And I think using explicit type annotations is not wrong anyway.

[codecov]

Codecov Report

Merging #344 into master will increase coverage by 0.31%.
The diff coverage is 85.71%.

@@            Coverage Diff            @@
##           master    #344      +/-   ##
=========================================
+ Coverage   87.69%     88%   +0.31%     
=========================================
  Files         337     331       -6     
  Lines       11182   11049     -133     
  Branches     1802    1780      -22     
=========================================
- Hits         9806    9724      -82     
+ Misses       1364    1313      -51     
  Partials       12      12

Impacted Files	Coverage Δ
components/core/src/animations/error-animations.ts	100% <100%> (ø)	⬆️
...omponents/expandable-panel/src/expandable-panel.ts	100% <100%> (ø)	⬆️
components/expandable-text/src/expandable-text.ts	100% <100%> (ø)	⬆️
...secondary-nav/src/section/secondary-nav-section.ts	90.9% <60%> (ø)	⬆️
components/table/src/expandable/expandable-row.ts	97.43% <66.66%> (ø)	⬆️
components/filter-field/src/filter-field.ts	92.98% <0%> (-0.4%)	⬇️
...ols/barista/src/markdown-custom-elements-ignore.ts
...op-bar-navigation/src/top-bar-navigation-module.ts
components/top-bar-navigation/src/index.ts
...nents/top-bar-navigation/src/top-bar-navigation.ts
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39bd68f...51d6caf. Read the comment docs.