Skip to content

Commit

Permalink
docs: format supported versions the same way across the readmes (open…
Browse files Browse the repository at this point in the history
…-telemetry#797)

Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
  • Loading branch information
rauno56 and vmarchaud authored Jan 4, 2022
1 parent f497313 commit a2b71cf
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 19 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ jobs:
npx lerna bootstrap --no-ci
# Release Please has already incremented versions and published tags, so we just
# need to publish all unpublished versions to NPM here
# need to publish all unpublished versions to npm here
# See: https://github.com/lerna/lerna/tree/main/commands/publish#bump-from-package
- name: Publish to NPM
- name: Publish to npm
if: ${{ steps.release.outputs.releases_created }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ This repo is generally meant for hosting components that work with popular open-

### Adding a New Vendor Component

Vendor components that are hosted in this repo will be versioned the same as all other contrib components, and released in lockstep with them under the `@opentelemetry` org in NPM.
Vendor components that are hosted in this repo will be versioned the same as all other contrib components, and released in lockstep with them under the `@opentelemetry` org in npm.

In exchange, vendor component contributors are expected to:

Expand Down
2 changes: 1 addition & 1 deletion RELEASING.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Releasing OpenTelemetry Packages (for Maintainers Only)

This repository uses [Release Please](https://github.com/googleapis/release-please) to manage its releases automatically and independently.
Modified packages are automatically published to NPM when the auto-generated Release Please PR is merged.
Modified packages are automatically published to npm when the auto-generated Release Please PR is merged.

## Manual Publishing Process

Expand Down
4 changes: 2 additions & 2 deletions plugins/node/opentelemetry-instrumentation-hapi/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[![devDependencies][devDependencies-image]][devDependencies-url]
[![Apache License][license-image]][license-image]

This module provides automatic instrumentation for [`Hapi`](https://hapi.dev).
This module provides automatic instrumentation for the [Hapi Framework](https://hapi.dev)(`@hapi/hapi` package).

For automatic instrumentation see the
[@opentelemetry/sdk-trace-node](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-node) package.
Expand All @@ -20,7 +20,7 @@ npm install --save @opentelemetry/instrumentation-hapi

### Supported Versions

- @hapi/hapi `^17.0.0`
- `>=17.0.0 <21`

## Usage

Expand Down
10 changes: 5 additions & 5 deletions plugins/node/opentelemetry-instrumentation-koa/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
[![devDependencies][devDependencies-image]][devDependencies-url]
[![Apache License][license-image]][license-image]

This module provides automatic instrumentation for [`Koa`](https://github.com/koajs/koa).
This module provides automatic instrumentation for [Koa](https://github.com/koajs/koa).

For automatic instrumentation see the
[@opentelemetry/sdk-trace-node](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-node) package.
[`@opentelemetry/sdk-trace-node`](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-node) package.

Compatible with OpenTelemetry JS API and SDK `1.0+`.

Expand All @@ -20,7 +20,7 @@ npm install --save @opentelemetry/instrumentation-koa

### Supported Versions

- Koa `^2.0.0`
- `^2.0.0`

## Usage

Expand All @@ -41,7 +41,7 @@ registerInstrumentations({
});
```

See [examples/koa](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/examples/koa) for a short example using both Koa and @koa/router
See [`examples/koa`](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/examples/koa) for a short example using both Koa and @koa/router

### Koa Instrumentation Options

Expand All @@ -56,7 +56,7 @@ See [examples/koa](https://github.com/open-telemetry/opentelemetry-js-contrib/tr

## Koa Packages

This package provides automatic tracing for middleware added using either the core [`Koa`](https://github.com/koajs/koa) package or the [`@koa/router`](https://github.com/koajs/router) package.
This package provides automatic tracing for middleware added using either the core [`koa`](https://github.com/koajs/koa) package or the [`@koa/router`](https://github.com/koajs/router) package.

## Useful links

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ npm install --save @opentelemetry/instrumentation-mongodb

### Supported Versions

- `'>=3.3 <4`
- `>=3.3 <4`

## Usage

Expand Down
11 changes: 4 additions & 7 deletions plugins/node/opentelemetry-instrumentation-pg/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[![devDependencies][devDependencies-image]][devDependencies-url]
[![Apache License][license-image]][license-image]

This module provides automatic instrumentation for [`pg and pg-pool`](https://github.com/brianc/node-postgres)
This module provides automatic instrumentation for [`pg`](https://github.com/brianc/node-postgres).

For automatic instrumentation see the
[@opentelemetry/sdk-trace-node](https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-node) package.
Expand All @@ -18,7 +18,9 @@ Compatible with OpenTelemetry JS API and SDK `1.0+`.
npm install --save @opentelemetry/instrumentation-pg
```

It will install Instrumentation for PG and PG-POOL
### Supported Versions

- `>=7 <9`

## Usage

Expand Down Expand Up @@ -50,11 +52,6 @@ PostgreSQL instrumentation has few options available to choose from. You can set
| [`enhancedDatabaseReporting`](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-pg/src/pg.ts#L48) | `boolean` | If true, additional information about query parameters and results will be attached (as `attributes`) to spans representing database operations |
| `responseHook` | `PgInstrumentationExecutionResponseHook` (function) | Function for adding custom attributes from db response |

## Supported Versions

- [pg](https://npmjs.com/package/pg): `7.x`, `8.*`
- [pg-pool](https://npmjs.com/package/pg-pool): `2.x`, `3.*` (Installed by `pg`)

## Useful links

- For more information on OpenTelemetry, visit: <https://opentelemetry.io/>
Expand Down

0 comments on commit a2b71cf

Please sign in to comment.