chore: add url to documentFetch span (open-telemetry#1129)

* chore: add url and HTTP_USER_AGENT to documentFetch span * chore: add unit test * chore: remove user agent from documentFetch span Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com>
dynatrace-oss-contrib · Sep 22, 2022 · 01d6e95 · 01d6e95
1 parent d463695
commit 01d6e95
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/plugins/web/opentelemetry-instrumentation-document-load/src/instrumentation.ts b/plugins/web/opentelemetry-instrumentation-document-load/src/instrumentation.ts
@@ -110,6 +110,7 @@ export class DocumentLoadInstrumentation extends InstrumentationBase<unknown> {
           entries
         );
         if (fetchSpan) {
+          fetchSpan.setAttribute(SemanticAttributes.HTTP_URL, location.href);
           context.with(trace.setSpan(context.active(), fetchSpan), () => {
             addSpanNetworkEvents(fetchSpan, entries);
             this._endSpan(fetchSpan, PTN.RESPONSE_END, entries);

diff --git a/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts b/plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts
@@ -544,6 +544,11 @@ describe('DocumentLoad Instrumentation', () => {
         assert.strictEqual(fetchSpan.name, 'documentFetch');
         assert.strictEqual(rootSpan.name, 'documentLoad');
 
+        assert.strictEqual(
+          fetchSpan.attributes['http.url'],
+          'http://localhost:9876/context.html'
+        );
+
         assert.strictEqual(
           rootSpan.attributes['http.url'],
           'http://localhost:9876/context.html'