Extract common functionality from SINDy to _BaseSINDy
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will eventually enable SSSindy.print, as well as a simpler discrete and SINDyPI class
SINDy.equations(), equations(), print_model() were written with extra generality that never ended up being used. This commit removes such generality and throws away these indirected helper functions in favor of a single method.
Jacob-Stevens-Haas
force-pushed
the
simultaneous
branch
from
5182f24
to
79f43bb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
==========================================
+ Coverage 95.30% 95.33% +0.02%
==========================================
Files 37 37
Lines 4046 4048 +2
==========================================
+ Hits 3856 3859 +3
+ Misses 190 189 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jacob-Stevens-Haas
force-pushed
the
simultaneous
branch
from
79f43bb
to
b7eac64
Compare
Also: * fix sphinx cross-linking error * remove unused print_model
Jacob-Stevens-Haas
force-pushed
the
simultaneous
branch
from
b7eac64
to
2b3871b
Compare
|
Hey Alan, I put you as a reviewer in case you want an eye into this process. This is the beginning of what we talked about in the last meeting. @AHsu98, @MalachiteWind, I'm going to add you as collaborators so you can review these changes too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin #351
This pull request begins the abstraction of the
SINDyclass, which handles a lot of methods with special cases, to a variety of classes that reflect fundamental differences between problem formulations. Here, I pull out_BaseSINDy, which contains basic information about the feature library, system dimension, and printing the equations.Future PRs will make Weak and discrete their own classes, modify feature libraries to be amenable to jax, numpy, and cvxpy arrays, and introduce the Single-Step SINDy class and associated optimizer/problem setup.