CI: Add raw build and import step (should fail) #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #543 +/- ##
==========================================
- Coverage 94.31% 94.22% -0.09%
==========================================
Files 37 37
Lines 4099 4105 +6
==========================================
+ Hits 3866 3868 +2
- Misses 233 237 +4 ☔ View full report in Codecov by Sentry. |
I'm not sure where this happened, but since ConstrainedSR3 needs CVXPY (an optional dependency), imports of it need to be guarded depending on whether user has cvxpy installed. Also, since PEP 690 was rejected, removed those comments
Jacob-Stevens-Haas
force-pushed
the
fix-import-issue
branch
from
0ab1bf4
to
e8ba8ea
Compare
Jacob-Stevens-Haas
force-pushed
the
fix-import-issue
branch
from
d22d2b8
to
4462537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529