Even faster tests 🚬 #393
Merged
Even faster tests 🚬 #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes check_is_fitted to fail, since that function uses the presence of underscored attributes as a proxy for the model having been fit. Also: promote the TrappingSR3 non-quadratic warning to a warning, not a print statement.
Also extracted relevant parts of test_trapping_inequality_constraints
Also extracted relevant parts of test_stable_linear_sr3_linear_library
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 93.76% 93.74% -0.02%
==========================================
Files 37 37
Lines 3590 3583 -7
==========================================
- Hits 3366 3359 -7
Misses 224 224
☔ View full report in Codecov by Sentry. |
Coarsen grid loosen integration tolerances loosen test tolerances. Tweak test parameters
Also shrink 1d data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the 🔬 to the slowest tests of
StableLinearSR3andTrappingSR3. Since test parameterization affected only the creation of CVXPY functions, I refactored that part out to speed up tests.This drops test time from around 45 sec to
3014 secCloses #320
@akaptano, if you get a chance to review, that would be great, since this mostly affects your code.
Edit: @znicolaou, I made all the changes to Weak/PDE library tests here too.