Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication - .netrc credential support #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cdjones32
Copy link

Hello. I've just started using this project over my hand-rolled version, and I'm very impressed!

However, I have a few enhancements I would like to discuss and validate that they are wanted by people other than just me before I continue any further.

The first one is the removal of credentials from the configuration file. I believe this would be a common requirement, and also a common security concern (I've even seen people make their credentials public in pull requests on this project). Additionally, it prevents someone from setting up and sharing a configuration (e.g. with a team).

This pull request has implemented a simple, standard mechanism for pulling the credentials from the users ~/.netrc file - a practice shared by many utilities (e.g. curl, ftp, httpie, etc.). The change is backward compatible and allows you to opt-in with a setting in your config file.

I've provided preliminary documentation, with an example, and done some simple testing on Mac, but I'm confident it would work equally well on Linux.

What still needs to be done:

  • Checking Windows support (I don't currently have access to a windows PC, but I could get it)
  • Checking integration with the 'export/save as' functionality. I've only implemented and tested the standard authentication process.
  • More complete documentation and testing.

Anyway, I just thought I would start the process to get comments/guidance on how to proceed.

Thanks for your time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant