Authentication - .netrc credential support #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I've just started using this project over my hand-rolled version, and I'm very impressed!
However, I have a few enhancements I would like to discuss and validate that they are wanted by people other than just me before I continue any further.
The first one is the removal of credentials from the configuration file. I believe this would be a common requirement, and also a common security concern (I've even seen people make their credentials public in pull requests on this project). Additionally, it prevents someone from setting up and sharing a configuration (e.g. with a team).
This pull request has implemented a simple, standard mechanism for pulling the credentials from the users ~/.netrc file - a practice shared by many utilities (e.g. curl, ftp, httpie, etc.). The change is backward compatible and allows you to opt-in with a setting in your config file.
I've provided preliminary documentation, with an example, and done some simple testing on Mac, but I'm confident it would work equally well on Linux.
What still needs to be done:
Anyway, I just thought I would start the process to get comments/guidance on how to proceed.
Thanks for your time...