rename directory of HermitCore's OS related files #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm surprised this was merged as a breaking change. Is there any way to make this change in a backward-compatible way? If not, can you run rustfmt and use rustversion on HermitCore to target the correct version for this change? |
The latest version of libstd provides a new location of the HermitCore's OS related files. The kernel depends on the latest version of libstd. Consequently, this PR renames the location.
|
Yes, these are breaking change. However, HermitCore is a tier 3 platform and depends on the nightly compiler. Currently, you have always to use the latest version. I used |
|
Thanks, I'll keep HermitCore on nightly support then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of libstd provides a new location of the HermitCore's OS related files. The kernel depends on the latest version of libstd. Consequently, this PR renames the location.