Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update readme with banner and some docs #11

Merged
merged 2 commits into from
Oct 25, 2023
Merged

feat: update readme with banner and some docs #11

merged 2 commits into from
Oct 25, 2023

Conversation

nilslice
Copy link
Member

No description provided.

@nilslice nilslice requested a review from G4Vi October 24, 2023 23:26
G4Vi
G4Vi approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@G4Vi G4Vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! Great idea to give usage instructions even with ARM macs.

Step 4. (Create the dummy header) can be removed. I can remove it from the README tomorrow.

@G4Vi
Copy link
Contributor

G4Vi commented Oct 25, 2023

I removed the unnecessary step and pushed to this branch.

@nilslice nilslice merged commit 22cd56f into main Oct 25, 2023
5 checks passed
@nilslice nilslice deleted the readme branch October 25, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G4Vi G4Vi G4Vi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilslice @G4Vi