This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Improve nix support with termite #1134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie. Using Nix, directory /etc/xdg does not exist, while $XDG_CONFIG_DIRS is set. Respect XDG directory precedence - Break loop on $XDG_CONFIG_DIRS when a config is found
|
I can verify that this works. It would be nice to merge this. |
hykilpikonna
approved these changes
Aug 12, 2022
hykilpikonna
added a commit
to hykilpikonna/hyfetch
that referenced
this pull request
Aug 12, 2022
… termite Upstream PR: dylanaraps/neofetch#1134 Thanks to @bessonm Co-authored-by: bessonm <besson.mael@gmail.com>
|
Thank you for your contribution! This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained. HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo. Read the "Running Updated Original Neofetch" section for more info! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Using Nix some apps get wrapped, hence a name like ".APP-wrapped", causing later failure when matching a terminal name for font detection.
Moreover, for termite, directory /etc/xdg does not exist with NixOS, while $XDG_CONFIG_DIRS is set, which needed additional lookup.
(I didn't explore with other terminal yet, but the problem might occur for others)
Before fix
After fix
Thanks for your work and review :)