Use bulk db updates for (un)marking multiple episodes as played or fa…

…vourite.
dyerc · Oct 2, 2022 · 5010e39 · 5010e39
1 parent f870245
commit 5010e39
Show file tree

Hide file tree

Showing 3 changed files with 60 additions and 32 deletions.
diff --git a/Doughnut/Library/Library.swift b/Doughnut/Library/Library.swift
@@ -407,6 +407,60 @@ class Library: NSObject {
     }
   }
 
+  func batchUpdateEpisodes(favourite: Bool, episodes: [Episode], completion: ((Result<[Episode], LibraryError>) -> Void)? = nil) {
+    dbQueue?.asyncWrite({ db in
+      let keys = episodes.compactMap { $0.id }
+      try Episode.filter(keys: keys)
+        .updateAll(db, Column("favourite").set(to: favourite))
+    }, completion: { _, result in
+      episodes.forEach {
+        $0.favourite = favourite
+      }
+
+      switch result {
+      case .success:
+        DispatchQueue.main.async {
+          self.delegate?.libraryUpdatedEpisodes(episodes: episodes)
+        }
+        completion?(.success(episodes))
+      case let .failure(error):
+        if let error = error as? DatabaseError {
+          Library.handleDatabaseError(error)
+          completion?(.failure(.databaseError(error)))
+        } else {
+          completion?(.failure(.unknown(error)))
+        }
+      }
+    })
+  }
+
+  func batchUpdateEpisodes(played: Bool, episodes: [Episode], completion: ((Result<[Episode], LibraryError>) -> Void)? = nil) {
+    dbQueue?.asyncWrite({ db in
+      let keys = episodes.compactMap { $0.id }
+      try Episode.filter(keys: keys)
+        .updateAll(db, Column("played").set(to: played))
+    }, completion: { _, result in
+      episodes.forEach {
+        $0.played = played
+      }
+
+      switch result {
+      case .success:
+        DispatchQueue.main.async {
+          self.delegate?.libraryUpdatedEpisodes(episodes: episodes)
+        }
+        completion?(.success(episodes))
+      case let .failure(error):
+        if let error = error as? DatabaseError {
+          Library.handleDatabaseError(error)
+          completion?(.failure(.databaseError(error)))
+        } else {
+          completion?(.failure(.unknown(error)))
+        }
+      }
+    })
+  }
+
   // Async episode save and event emission
   func save(episode: Episode, completion: ((Result<Episode, LibraryError>) -> Void)? = nil) {
     dbQueue?.asyncWrite({ db in

diff --git a/Doughnut/View Controllers/EpisodeViewController.swift b/Doughnut/View Controllers/EpisodeViewController.swift
@@ -449,10 +449,7 @@ final class EpisodeViewController: NSViewController, NSTableViewDelegate, NSTabl
 
     let shouldMarkPlayed = !allPlayed
 
-    for episode in episodes {
-      episode.played = shouldMarkPlayed
-      Library.global.save(episode: episode)
-    }
+    Library.global.batchUpdateEpisodes(played: shouldMarkPlayed, episodes: episodes)
   }
 
   @IBAction func toggleFavourite(_ sender: Any) {
@@ -462,10 +459,7 @@ final class EpisodeViewController: NSViewController, NSTableViewDelegate, NSTabl
 
     let shouldMarkAsFavourite = !allMarkedAsFavourite
 
-    for episode in activeEpisodesForAction() {
-      episode.favourite = shouldMarkAsFavourite
-      Library.global.save(episode: episode)
-    }
+    Library.global.batchUpdateEpisodes(favourite: shouldMarkAsFavourite, episodes: episodes)
   }
 
   @IBAction func downloadEpisode(_ sender: Any) {

diff --git a/Doughnut/View Controllers/PodcastViewController.swift b/Doughnut/View Controllers/PodcastViewController.swift
@@ -333,34 +333,14 @@ final class PodcastViewController: NSViewController, NSTableViewDelegate, NSTabl
 
   @IBAction func markAllAsPlayed(_ sender: Any) {
     let podcasts = activePodcastsForAction()
-
-    for podcast in podcasts {
-      for episode in podcast.episodes {
-        episode.played = true
-      }
-
-      // Manually trigger a view reload to make update seem instant
-      viewController.libraryUpdatedPodcasts(podcasts: [podcast])
-
-      // Commit changes to library
-      Library.global.update(podcast: podcast)
-    }
+    let episodes = podcasts.flatMap { $0.episodes }
+    Library.global.batchUpdateEpisodes(played: true, episodes: episodes)
   }
 
   @IBAction func markAllAsUnplayed(_ sender: Any) {
     let podcasts = activePodcastsForAction()
-
-    for podcast in podcasts {
-      for episode in podcast.episodes {
-        episode.played = false
-      }
-
-      // Manually trigger a view reload to make update seem instant
-      viewController.libraryUpdatedPodcasts(podcasts: [podcast])
-
-      // Commit changes to library
-      Library.global.update(podcast: podcast)
-    }
+    let episodes = podcasts.flatMap { $0.episodes }
+    Library.global.batchUpdateEpisodes(played: false, episodes: episodes)
   }
 
   @IBAction func copyPodcastURL(_ sender: Any) {