Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound effects for chat messages #999

Merged
merged 8 commits into from
Jul 13, 2023
Merged

Add sound effects for chat messages #999

merged 8 commits into from
Jul 13, 2023

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Jul 13, 2023

  • add pop sfx
  • add Sfx plugin
  • let sfx volume be controlled
  • have room view load sfx on mount
  • optimize sfx playback a little
  • play pop sfx on new chat messages
  • add client settings for sfx

related: #791

@cypress
Copy link

cypress bot commented Jul 13, 2023

1 failed tests on run #422 ↗︎

1 71 0 0 Flakiness 0

Details:

Merge 75b194f into 28565fd...
Project: OpenTogetherTube Commit: 8488911fa0 ℹ️
Status: Failed Duration: 04:54 💡
Started: Jul 13, 2023 4:26 PM Ended: Jul 13, 2023 4:31 PM
Failed  client/tests/e2e/component/AddPreview.cy.ts • 1 failed test • Component - electron

View Output Video

Test Artifacts
An uncaught error was detected outside of a test Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #999 (75b194f) into master (28565fd) will increase coverage by 0.2386%.
The diff coverage is 49.1525%.

@@               Coverage Diff                @@
##             master       #999        +/-   ##
================================================
+ Coverage   58.4472%   58.6858%   +0.2386%     
================================================
  Files           109        110         +1     
  Lines          8411       8675       +264     
  Branches       1054       1054                
================================================
+ Hits           4916       5091       +175     
- Misses         3495       3584        +89     
Impacted Files Coverage Δ
client/src/components/Chat.vue 100.0000% <ø> (ø)
client/src/views/Room.vue 51.2331% <16.6666%> (-0.2341%) ⬇️
client/src/plugins/sfx.ts 39.7435% <39.7435%> (ø)
client/src/components/ClientSettingsDialog.vue 65.5737% <65.2173%> (-0.7629%) ⬇️
client/src/locales/en.ts 100.0000% <100.0000%> (ø)
client/src/stores/settings.ts 70.4918% <100.0000%> (+2.0707%) ⬆️

... and 1 file with indirect coverage changes

@dyc3 dyc3 merged commit 89cfb0c into master Jul 13, 2023
@dyc3 dyc3 deleted the chat-sounds branch July 13, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant