Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using zod for validation on voting API endpoints #1476

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Switch to using zod for validation on voting API endpoints #1476

merged 8 commits into from
Mar 12, 2024

Conversation

Victor-M-Giraldo
Copy link
Contributor

Related #1385

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@Victor-M-Giraldo Victor-M-Giraldo changed the title zod validation for voting Switch to using zod for validation on voting API endpoints Mar 11, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 29.62963% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 55.9990%. Comparing base (ab5242f) to head (fb79bac).
Report is 1 commits behind head on master.

Files Patch % Lines
common/models/zod-schemas.ts 0.0000% 12 Missing and 1 partial ⚠️
server/api/room.ts 45.4545% 6 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##             master      #1476        +/-   ##
================================================
+ Coverage   55.9982%   55.9990%   +0.0008%     
================================================
  Files           162        162                
  Lines         24774      24779         +5     
  Branches       1423       1423                
================================================
+ Hits          13873      13876         +3     
- Misses        10847      10849         +2     
  Partials         54         54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Victor-M-Giraldo
Copy link
Contributor Author

Couple of things.

  • Do you want unit tests for these?
  • I run tests on my end and I get a bunch of weird output. Been happening for a while and I've tried finding out why on Google/Stack and no clue. See here

dyc3
dyc3 requested changes Mar 11, 2024
View reviewed changes
common/models/zod-schemas.ts Show resolved Hide resolved
server/api/room.ts Show resolved Hide resolved
@dyc3
Copy link
Owner

dyc3 commented Mar 12, 2024

Is this ready?

@Victor-M-Giraldo
Copy link
Contributor Author

Think so.

@Victor-M-Giraldo Victor-M-Giraldo marked this pull request as ready for review March 12, 2024 16:42
dyc3
dyc3 requested changes Mar 12, 2024
View reviewed changes
Copy link
Owner

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple minor changes

server/api/room.ts Show resolved Hide resolved
server/api/room.ts Show resolved Hide resolved
@dyc3 dyc3 enabled auto-merge (squash) March 12, 2024 19:14
@dyc3 dyc3 merged commit 50fe3a1 into dyc3:master Mar 12, 2024
19 of 20 checks passed
@cypress Cypress
Copy link

cypress bot commented Mar 12, 2024 •
edited
Loading

Passing run #1274 ↗︎

0 23 0 0 Flakiness 0

Details:

Switch to using zod for validation on voting API endpoints (#1476)
Project: OpenTogetherTube Commit: 50fe3a1db4
Status: Passed Duration: 02:04 💡
Started: Mar 12, 2024 9:26 PM Ended: Mar 12, 2024 9:28 PM

Review all test suite changes for PR #1476 ↗︎

@Victor-M-Giraldo Victor-M-Giraldo deleted the zod-validation-for-voting branch March 12, 2024 20:22
Victor-M-Giraldo added a commit to Victor-M-Giraldo/opentogethertube that referenced this pull request Mar 12, 2024
@Victor-M-Giraldo
Switch to using zod for validation on voting API endpoints (dyc3#1476)
24f031f 
* add voteSchema to OttApiRequestVote

* add voteSchema validation to addVote API endpoint

* add voteSchema validation to removeVote API endpoint

* made requested changes

* update naming convention

* fix lint

* use body in makeRoomRequest calls

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Victor-M-Giraldo @dyc3