Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(picklist-support): fix check for empty records on org #1341

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

Rocko1204
Copy link
Contributor

@Rocko1204 Rocko1204 commented Jul 4, 2023

Summary generated by Reviewpad on 04 Jul 23 08:06 UTC

This pull request fixes a check for empty records on the org in the PicklistEnabler.ts file. The patch includes changes to the isEnabled and execute methods, as well as other modifications to improve the functionality.

  • fix empty record check on org line 78
  • add try catch block to the deployment process , to go out (it can happen that we have duplicate labels in the deployment)

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot requested a review from gnemiq July 4, 2023 08:06
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 4, 2023
@reviewpad
Copy link

reviewpad bot commented Jul 4, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'hotfix(picklist-support): fix check for empty records on org' (32bc281)

⚠️ Warnings

  • Please link an issue to the pull request

@Rocko1204 Rocko1204 changed the title hotfix(picklist-support): fix check for empty records on org fix(picklist-support): fix check for empty records on org Jul 4, 2023
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azlam-abdulsalam azlam-abdulsalam merged commit 25c7177 into main Jul 4, 2023
@azlam-abdulsalam azlam-abdulsalam deleted the hotfix-picklist-update-jul23 branch July 4, 2023 14:41
azlam-abdulsalam pushed a commit that referenced this pull request Aug 11, 2023
hotfix(picklist-support): fix check for empty records on org
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants