Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Filter class coverage by package #112

Merged
merged 11 commits into from
Aug 3, 2020
Merged

Conversation

aly76
Copy link
Contributor

@aly76 aly76 commented Aug 1, 2020

Two new parameters in Trigger Apex Test to be used when validating class coverage:

  • Package to validate
  • Project directory

Refactored Trigger Apex Test core implementation

@aly76 aly76 added the enhancement enhancement to existing feature label Aug 1, 2020
@aly76 aly76 requested a review from azlam-abdulsalam August 1, 2020 04:32
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minore changes required

packages/core/src/getPackageManifest.ts Outdated Show resolved Hide resolved
packages/core/src/sfdxwrappers/TriggerApexTestImpl.ts Outdated Show resolved Hide resolved
@@ -147,6 +112,7 @@ export default class TriggerApexTestImpl {
let code_coverage_json = JSON.parse(code_coverage);

if (!isNullOrUndefined(packageClasses)) {
// only include package classes in code coverage report
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this logic to another function block?

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need minor changes

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bump Required enhancement enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants