Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hapi v18 #295

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Support for hapi v18 #295

merged 1 commit into from
Jan 21, 2019

Conversation

devinivy
Copy link
Contributor

This tests the library on hapi v18 (release notes) and adds hapi's new plugin requirements to express the peer dependency on hapi in a way that can be enforced at runtime (see hapijs/hapi#3867).

@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #295   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         110    111    +1     
=====================================
+ Hits          110    111    +1
Impacted Files Coverage Δ
lib/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6f5b5...20db183. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devinivy thanks for the update. 👍
Hope you are well. ☀️

@nelsonic nelsonic merged commit 8415915 into dwyl:master Jan 21, 2019
@nelsonic
Copy link
Member

hapi-auth-jwt2@8.3.0 published on NPM includes compatibility for v18. hapijs/hapi#3871

nelsonic added a commit that referenced this pull request Jan 21, 2019
@devinivy devinivy deleted the hapi-v18 branch January 21, 2019 20:01
@devinivy
Copy link
Contributor Author

Cheers! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants