Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create auth page #18

Merged
merged 8 commits into from
Apr 1, 2020
Merged

create auth page #18

merged 8 commits into from
Apr 1, 2020

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Apr 1, 2020

Create html page for auth login buttons

@SimonLab SimonLab self-assigned this Apr 1, 2020
@SimonLab SimonLab temporarily deployed to auth-mvp-test April 1, 2020 12:20 Inactive
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #18 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        15    -1     
  Lines           70        68    -2     
=========================================
- Hits            70        68    -2     
Impacted Files Coverage Δ
...ib/auth_mvp_web/controllers/auth_url_controller.ex 100.00% <100.00%> (ø)
lib/auth_mvp_web/router.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f027488...7fffb3a. Read the comment docs.

@SimonLab SimonLab requested a review from nelsonic April 1, 2020 17:59
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Apr 1, 2020
<h1>Welcome to DWYL Authentication App!</h1>
<p>To get started, login to your Google or Github ccount: <p>
<a href="<%= @oauth_google_url %>">
<img src="https://i.imgur.com/Kagbzkq.png" alt="Sign in with Google" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab using the <img> button is fine for now. 👍
At some point we can convert them to SVG for consistency. see: dwyl/auth#44

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good. thanks! 👍

@nelsonic nelsonic merged commit 9836d31 into master Apr 1, 2020
@nelsonic nelsonic deleted the auth-page branch April 1, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants