Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed pandas future warn about as_matrix #37

Merged
merged 1 commit into from
May 30, 2018
Merged

fixed pandas future warn about as_matrix #37

merged 1 commit into from
May 30, 2018

Conversation

sroet
Copy link
Collaborator

@sroet sroet commented May 21, 2018

Since pandas version 0.23 a FutureWarning popped up:

contact_map/tests/test_contact_count.py::TestContactCount::()::test_df
  /home/sander/github_files/contact_map/contact_map/tests/test_contact_count.py:74: FutureWarning: Method .as_matrix will be removed in a future version. Use .values instead.
    assert_array_equal(atom_df.to_dense().as_matrix(),
  /home/sander/github_files/contact_map/contact_map/tests/test_contact_count.py:76: FutureWarning: Method .as_matrix will be removed in a future version. Use .values instead.
    assert_array_equal(residue_df.to_dense().as_matrix(),

This fixes that warning in the way proposed by the warning

dwhswenson
dwhswenson approved these changes May 30, 2018
View reviewed changes
Copy link
Owner

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merging.

@dwhswenson dwhswenson merged commit 277289a into dwhswenson:master May 30, 2018
@dwhswenson dwhswenson added misc PR upstream_changed PR in response to changes in dependencies labels May 31, 2018
@dwhswenson dwhswenson mentioned this pull request Jun 3, 2019
Merged
@sroet sroet deleted the fix_pandas_future_warn branch July 7, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwhswenson dwhswenson dwhswenson approved these changes

Assignees
No one assigned
Labels
misc PR upstream_changed PR in response to changes in dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sroet @dwhswenson