Fix lines missing from test coverage #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwhswenson
changed the title
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
===========================================
+ Coverage 99.53% 100.00% +0.46%
===========================================
Files 13 13
Lines 1070 1066 -4
===========================================
+ Hits 1065 1066 +1
+ Misses 5 0 -5
Continue to review full report at Codecov.
|
|
CodeCov agrees -- we are 💯! Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test suite currently fails to cover 5 lines. This PR should fix that.
with_colorbaroption wasn't passed fromContactCount.plottoContactCount.plot_axesin rework plotting to allow for plot_axes #79. This PR adds that functionality back in.ContactObject.atom_contactsandContactObject.residue_contactsare now overridden in all subclasses. It used to be thatContactMapused these, butContactMapwas removed in RemoveContactMap(allowing renameContactFrequency=>ContactMap) #88. This PR makes those explicitly abstract by raisingNotImplementedError.