Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No MPRIS in Flatpak installations #226

Closed
sol8712 opened this issue Jul 24, 2023 · 12 comments · Fixed by flathub/io.github.dweymouth.supersonic#25
Closed

No MPRIS in Flatpak installations #226

sol8712 opened this issue Jul 24, 2023 · 12 comments · Fixed by flathub/io.github.dweymouth.supersonic#25
Labels
bug Something isn't working

Comments

@sol8712
Copy link

sol8712 commented Jul 24, 2023

Supersonic Flatpak 0.5.1
Im not able to use my usual MPRIS enabled media keys, and no media info is shown in GNOME notification area.

On my install i have disabled the Pop! OS specific "cosmic desktop" extension in favor of the vanilla GNOME workflow.

Later i will test a mostly fresh Ubuntu 22.04 install and see if the issue persists there as well, if it does ill create a separate issue for that distro.

@sol8712
Copy link
Author

sol8712 commented Jul 24, 2023

Could be either a Flatpak related issue, a OS/distro specific issue, or a GNOME 42 issue.

@sol8712 sol8712 changed the title No MPRIS in Pop! OS 22.04(Ubuntu). GDM 42.0 No MPRIS in Pop! OS 22.04(Ubuntu)/GNOME 42.0 Jul 24, 2023
@dweymouth
Copy link
Owner

My guess is on it being a Flatpak issue. Could you try with the direct download of the executable from the GitHub Releases page? @anarcat Might there be a new permission that needs to be enabled to allow MPRIS D-Bus access?

@sol8712
Copy link
Author

sol8712 commented Jul 24, 2023

My guess is on it being a Flatpak issue. Could you try with the direct download of the executable from the GitHub Releases page? @anarcat Might there be a new permission that needs to be enabled to allow MPRIS D-Bus access?

Direct download worked as expected! All expected MRPIS functions work great!
Now i can control music locally on on my media center PC with my keyboard as well as any android device through KDE connect/GSconnect.
This is a wonderful addition! Thank you for all you work @dweymouth and all of team Supersonic!

@dweymouth dweymouth changed the title No MPRIS in Pop! OS 22.04(Ubuntu)/GNOME 42.0 No MPRIS in Flatpak installations Jul 24, 2023
@dweymouth dweymouth added the bug Something isn't working label Jul 24, 2023
@sol8712

This comment was marked as off-topic.

anarcat added a commit to flathub/io.github.dweymouth.supersonic that referenced this issue Jul 25, 2023
@anarcat
Copy link
Contributor

anarcat commented Jul 25, 2023

i made a PR attempting to fix this in the flatpak, do you think you could test the build when it's done to confirm it works?

flathub/io.github.dweymouth.supersonic#25

@anarcat
Copy link
Contributor

anarcat commented Jul 25, 2023

build passed, i merged and this should end up on flathub soon-ish.

(to be honest i never quite know when builds land on flathub. in this case, i think the 0.5.1 release might get overwritten with the recent changes i made, but i don't quite understand how it works, let alone when those changes do propagate. last time i asked flathub folks about this, they pointed me at https://buildbot.flathub.org and there you can see the current master being built at https://buildbot.flathub.org/#/builders/6/builds/54987... but it doesn't show the build being uploaded when done. so who knows.)

@jcharaoui
Copy link

The build page suggests the unpublished builds are of type Test while the latest published ones are Official.

@jcharaoui
Copy link

jcharaoui commented Jul 26, 2023

i made a PR attempting to fix this in the flatpak, do you think you could test the build when it's done to confirm it works?

Tested the latest version on my system (Debian 12), and media keys are still not working, and I'm not seeing any media notification from Supersonic.

@dweymouth
Copy link
Owner

This PR may fix it: flathub/io.github.dweymouth.supersonic#27

@jcharaoui would you be able to test the build? flatpak install --user https://dl.flathub.org/build-repo/38645/io.github.dweymouth.supersonic.flatpakref

@anarcat
Copy link
Contributor

anarcat commented Jul 31, 2023

This PR may fix it: flathub/io.github.dweymouth.supersonic#27

who knows! :) let's try! i just merged the PR.

@jcharaoui would you be able to test the build? flatpak install --user https://dl.flathub.org/build-repo/38645/io.github.dweymouth.supersonic.flatpakref

... and soon directly on flathub, YOLO!

@jcharaoui
Copy link

It works now, thanks!

@anarcat
Copy link
Contributor

anarcat commented Jul 31, 2023

@dweymouth i think this ticket can be closed, thanks @jcharaoui for the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants