Add a method for calculating num_edges #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcondello
reviewed
Jun 14, 2024
dwave/optimization/model.pyx
Outdated
| >>> model.num_edges() | ||
| 0 | ||
| """ | ||
| return sum(1 for sym in self.iter_symbols() for _ in sym.iter_successors()) |
There was a problem hiding this comment.
We might as well do the more performant thing. Something like
cdef Py_ssize_t num_edges = 0
for i in range(self._graph.num_nodes()):
num_edges += self._graph.nodes()[i].successors().size()
return num_edges
arcondello
reviewed
Jun 17, 2024
dwave/optimization/model.pyx
Outdated
Comment on lines
701
to
702
| This example add a single (size 20) decision symbol and | ||
| a single (size 3) constant symbol checks the number of |
There was a problem hiding this comment.
I think these numbers are incorrect?
There was a problem hiding this comment.
Ughh, forgot to update this. Thanks!
| --- | ||
| features: | ||
| - | | ||
| Adds a method for calculating num_edges |
There was a problem hiding this comment.
Maybe something like
Add `Model.num_edges()` method. See `#28 <https://github.com/dwavesystems/dwave-optimization/issues/28>`_.
arcondello
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28