Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML file for RTD #123

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Conversation

JoelPasvolsky
Copy link
Collaborator

No description provided.

Copy link
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.readthedocs.yml Outdated
Comment on lines 13 to 15
- requirements: docs/requirements.txt
- method: pip
path: .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd invert those two, as docs deps naturally extend package deps.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@randomir randomir mentioned this pull request Apr 12, 2021
.readthedocs.yml Outdated
Comment on lines 13 to 15
- method: pip
- requirements: docs/requirements.txt
path: .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax error. RtD build should fail on this. path has to go together with method.

@arcondello arcondello merged commit 3b6294f into dwavesystems:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants