Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use steepest descent solver in greedy samplers #250

Conversation

randomir
Copy link
Member

Close #249.

@codecov-commenter
Copy link

Codecov Report

Merging #250 (658a131) into master (e43522a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files          17       17           
  Lines        1872     1872           
=======================================
  Hits         1676     1676           
  Misses        196      196           
Impacted Files Coverage Δ
hybrid/samplers.py 91.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43522a...658a131. Read the comment docs.

@randomir randomir merged commit 0ab0723 into dwavesystems:master Sep 20, 2021
@randomir randomir deleted the bugfix/actually-use-greedy-in-greedy-sampler/issue-249 branch September 20, 2021 22:35
randomir added a commit that referenced this pull request Oct 4, 2021
New Features
---
- `make_origin_embeddings` problem decomposing utility that creates
  optimal embeddings for a lattice. Embeddings are compatible with
  the topology and shape of D-Wave QPU samplers
  (#252).
- `SublatticeDecomposer` that produces lattice-structured subproblems
  (#252).

Fixes
---
- `SteepestDescentProblemSampler` now actually uses
  `greedy.SteepestDescentSolver`
  (#250).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SteepestDescentProblemSampler not using SteepestDescentSolver
2 participants