Use M1 resource class for macos builds on CircleCI #1374
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1374 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 97 97
Lines 10368 10368
=======================================
Hits 9831 9831
Misses 537 537 ☔ View full report in Codecov by Sentry. |
| @@ -259,7 +267,7 @@ jobs: | |||
| python -m venv env | |||
| . env/bin/activate | |||
| pip install dimod --no-index -f dist/ --force-reinstall --no-deps | |||
| pip install << parameters.dependencies >> --upgrade --only-binary=numpy | |||
| pip install "<< parameters.dependencies >>" --upgrade --only-binary=numpy | |||
There was a problem hiding this comment.
I recommend quoting individual specifiers -- below in the list of parameter values -- not the parameter value here. That way you can use multiple specifiers per parameter (e.g. "'numpy<2' scipy~=1.0"). For example, see cloud-client's config, or dwave-inspector's one.
Alternatively, you can use tilde in version specifier, and avoid quoting altogether.
There was a problem hiding this comment.
I will likely revert this commit as part of the NumPy 2.0 PR, so I will leave it be for now.
.circleci/config.yml
Outdated
| @@ -3,6 +3,7 @@ version: 2.1 | |||
| orbs: | |||
| codecov: codecov/codecov@3 | |||
| win: circleci/windows@5.0.0 | |||
| macos: circleci/macos@2.4.1 | |||
There was a problem hiding this comment.
It's probably fine to reduce precision to minor or major version here, that way the latest is used.
I'll uncap the NumPy version in another PR (i.e., #1373).
See also dwavesystems/dwave-ocean-sdk#294.