all: follow up on libfuzzer change #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes of note: * Add instructions on README * Switch from using 'var _ = _go_fuz_dep_.Main' to 'var _ = _go_fuz_dep_.CoverTab' to avoid "imported but not used" errors in instrumented code. This is because CoverTab is always present, but libFuzzer code doesn't need Main. * Switch from a format string to text/template to generate the main package. * Rework the 'go build' command at the core of buildInstrumentedBinary. Passing an empty "extraBuildFlags" to go build does not work: go build interprets the empty string as a package name. Also, don't bother renaming outf; it gets renamed (for libfuzzer) or read and deleted (for go-fuzz) later. * Extract shared code from go-fuzz-dep main.go/main_libFuzzer.go, so that the only code in each is truly specific to that target.
This was referenced Mar 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for details about what has changed and why.
I do not have ready access to a linux box to test that
go-fuzz-build -libfuzzerstill works after this change. I'd love it if someone could do a sanity check. (I should have done that on the previous PR!)